feat(table): add support for line alignment in the table widget #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkcdarunday
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 85.02% 85.09% +0.06%
==========================================
Files 40 40
Lines 8683 8707 +24
==========================================
+ Hits 7383 7409 +26
+ Misses 1300 1298 -2
|
orhun
approved these changes
Aug 11, 2023
kdheepak
approved these changes
Aug 12, 2023
|
Nice! Welcome to ratatui and thanks for the PR - looks like there were a few +1s on that issue. |
joshka
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Cellobjects already internally contain instances ofLineandLinealready has alignment info, we can use this to position a line of text inside a table cell.This PR makes the table render function follow the text line alignment and resolves #257