Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all demo gifs to github #401

Closed
kdheepak opened this issue Aug 12, 2023 · 6 comments
Closed

Move all demo gifs to github #401

kdheepak opened this issue Aug 12, 2023 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@kdheepak
Copy link
Collaborator

Problem

Currently a lot of the demo gifs are on vhs's website. For reliability, we might want to consider moving them to github.

Solution

We don't want to bloat the repo git history. So we can either:

  1. Upload gifs to a separate git repo
  2. Upload gifs to a gist in a comment or in a README.md file
  3. Upload gifs to a release
@kdheepak kdheepak added the enhancement New feature or request label Aug 12, 2023
@hasezoey
Copy link
Contributor

also consider using git lfs

@joshka
Copy link
Member

joshka commented Aug 13, 2023

also consider using git lfs

Good idea, but we might hit quotas pretty quickly with that:

Demo.gif is 2.8MB, the monthly quota on github's lfs is just 1GiB, and the readme was visited 5475 times in the last 2 weeks (e.g. 15.3GB just for that image), VHS also supports mp4 (651KB->3.6GB), and webm (846KB->4.6GB). I'm unsure how those would render on crates.io, but they look ok on Github. E.g.:

demo.mp4
demo.webm

@joshka
Copy link
Member

joshka commented Aug 13, 2023

+1 to the idea. I'd like this to be easy to automate both in CI and locally.

@orhun
Copy link
Sponsor Member

orhun commented Aug 13, 2023

Yeah we totally need this...

@joshka
Copy link
Member

joshka commented Sep 2, 2023

I took the approach of creating a new branch to store the gifs. https://github.com/ratatui-org/ratatui/tree/images

@joshka
Copy link
Member

joshka commented Sep 16, 2023

Done

@joshka joshka closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants