Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(span): finish docs and tests for Span #427

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Aug 24, 2023

image

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #427 (1097f3d) into main (80fd77e) will increase coverage by 0.38%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   87.08%   87.46%   +0.38%     
==========================================
  Files          40       40              
  Lines        9822    10139     +317     
==========================================
+ Hits         8553     8868     +315     
- Misses       1269     1271       +2     
Files Changed Coverage Δ
src/text/span.rs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@mindoodoo mindoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nitpicks otherwise LGTM ! Thanks for this PR, was needed !

src/text/span.rs Outdated Show resolved Hide resolved
src/text/span.rs Outdated Show resolved Hide resolved
src/text/span.rs Outdated Show resolved Hide resolved
@joshka joshka force-pushed the feat-line-wrap branch 2 times, most recently from 795dcda to 3c70819 Compare August 25, 2023 05:39
@joshka
Copy link
Member Author

joshka commented Aug 25, 2023

Updated wording to simplify it somewhat. My reason for being more verbose than necessary is to make it easy on new rust developers (who may not have seen used Cow), and older tui-rs developers that may not be aware of the Stylize trait and the shortcut methods.


Screen Shot 2023-08-24 at 22 49 20

@joshka joshka added this pull request to the merge queue Aug 25, 2023
Merged via the queue into ratatui-org:main with commit d0ee04a Aug 25, 2023
30 checks passed
@joshka joshka deleted the feat-line-wrap branch August 25, 2023 09:15
@joshka joshka added this to the v0.23.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants