refactor(barchart): reduce some calculations #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthago1
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 87.97% 89.95% +1.97%
==========================================
Files 40 40
Lines 10279 10876 +597
==========================================
+ Hits 9043 9783 +740
+ Misses 1236 1093 -143
|
karthago1
force-pushed
the
hich/barchart
branch
2 times, most recently
from
aede4eb
to
ebfa888
Compare
Calculating the label_offset is unnecessary, if we just render the group label after rendering the bars. We can just reuse bar_y. Signed-off-by: Ben Fekih, Hichem <hichem.f@live.de>
karthago1
force-pushed
the
hich/barchart
branch
from
ebfa888
to
194802f
Compare
joshka
approved these changes
Aug 27, 2023
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating
label_offsetis unnecessary, if we just render the group label after rendering the bars. We can just reusebar_y.this commit is getting rid of
let label_offset = bars.len() as u16 * (self.bar_width + self.bar_gap) - self.bar_gap;