chore: disable default benchmarking #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindoodoo
requested review from
orhun,
sayanarijit,
joshka and
kdheepak
as code owners
orhun
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 41 41
Lines 11571 11571
=======================================
Hits 10363 10363
Misses 1208 1208 |
mindoodoo
force-pushed
the
disable-bench
branch
from
ec7384b
to
d5075ee
Compare
Disables the default benchmarking behaviour for the lib target to fix unrecognized criterion benchmark arguments.
mindoodoo
force-pushed
the
disable-bench
branch
from
d5075ee
to
a886944
Compare
joshka
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the default benchmarking behaviour for the lib target to fix unrecognized criterion benchmark arguments as specified in the FAQ of criterion.
I came accross this error when trying to save a baseline for the benchmarks using the
--save-baselineoption.