Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: define struct WrappedLine instead of anonymous tuple #608

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

progval
Copy link
Contributor

@progval progval commented Nov 2, 2023

It makes the type easier to document, and more obvious for users, given that #607 makes this part of the public API

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we probably just want to get rid of reflow, this makes the code incrementally easier to understand, so approving this for now regardless.

@joshka
Copy link
Member

joshka commented Nov 29, 2023

This needs a small update to rebase on the conflicts.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd22e72) 90.9% compared to head (d5db9da) 90.9%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #608   +/-   ##
=====================================
  Coverage   90.9%   90.9%           
=====================================
  Files         42      42           
  Lines      12533   12542    +9     
=====================================
+ Hits       11394   11403    +9     
  Misses      1139    1139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka
Copy link
Member

joshka commented Dec 4, 2023

Hey would you mind signing your commit with gpg and force pushing a change with this (and the updates for the conflicts)

See
https://github.com/ratatui-org/ratatui/blob/main/CONTRIBUTING.md#sign-your-commits for more info.

@progval progval force-pushed the wrappedline branch 5 times, most recently from 732ad3c to 9552ec2 Compare December 4, 2023 07:37
@Valentin271
Copy link
Member

Hi, could you run cargo +nightly fmt and force push so we can merge this PR

@Valentin271 Valentin271 added this to the v0.25.0 milestone Dec 6, 2023
It makes the type easier to document, and more obvious for users
@progval
Copy link
Contributor Author

progval commented Dec 6, 2023

I rebased instead

@Valentin271
Copy link
Member

Works for me, thanks!

@Valentin271 Valentin271 merged commit 7ced7c0 into ratatui-org:main Dec 6, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants