Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix new clippy lint which triggers on table widths tests #630

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Nov 16, 2023

  • fix(table): widths() now accepts AsRef<[Constraint]>
  • fix(table): new clippy lint in 1.74.0 triggers on table widths tests

@joshka joshka changed the title table widths refs fix(table): new clippy lint in 1.74.0 triggers on table widths tests Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36d8c53) 90.4% compared to head (be84a30) 90.4%.

❗ Current head be84a30 differs from pull request most recent head 5495121. Consider uploading reports for the commit 5495121 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #630     +/-   ##
=======================================
- Coverage   90.4%   90.4%   -0.1%     
=======================================
  Files         41      41             
  Lines      11907   11903      -4     
=======================================
- Hits       10775   10771      -4     
  Misses      1132    1132             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun changed the title fix(table): new clippy lint in 1.74.0 triggers on table widths tests fix(table): fix new clippy lint which triggers on table widths tests Nov 16, 2023
@orhun orhun merged commit 1f88da7 into main Nov 16, 2023
31 checks passed
@orhun orhun deleted the table-widths-refs branch November 16, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants