docs: remove simple-tui-rs #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
kdheepak
as code owners
|
Maybe we can ping the maintainer of that repo here and let them know before merging this? (in case they might want to update the template) |
This has not been recently and doesn't lead to good code
joshka
force-pushed
the
remove-simple-tui-rs
branch
from
d86f18a
to
87ce2d2
Compare
|
ping @pmsanford |
|
The context on this is that a user in discord mentioned they were using this repo as a base because it seemed like the right idea. It may have been way back when tui-rs was just a young project, but it's got a few things would be better not to use in a newer project.
|
|
Thanks for the ping; I'd be happy to update it, but I can't make any commitments on a timeline at the moment. I'd suggest going ahead with merging this PR and when/if I get it updated I'll open one to re-add it. I'll also add a note to my repo saying it's not up to date and link to this PR. |
|
Sounds good, thank you! |
orhun
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not been recently and doesn't lead to good code