fix(block): make inner aware of title positions

[jan-ferdinand]

Previously, when computing the inner rendering area of a block, all titles were assumed to be positioned at the top. If some or all titles were at the bottom, this caused various incorrect computations of the inner area, depending on which borders were set; no border at the bottom would lead to an area that's too big, no border at the top but at the bottom and all titles at the bottom would lead to an area that's too small.

Now, when computing the inner area, the positions of the titles are taken into account.

fix #658

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1229b96) 90.7% compared to head (40b7a6b) 90.7%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #657   +/-   ##
=====================================
  Coverage   90.7%   90.7%           
=====================================
  Files         42      42           
  Lines      12170   12249   +79     
=====================================
+ Hits       11042   11121   +79     
  Misses      1128    1128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[orhun]

Can you also add a test case where you cover the issue in #658? (you can assert the contents of the buffer with assert_buffer)

[jan-ferdinand]

add a test case where you cover the issue in #658

Good suggestion. I have amended the PR accordingly. Let me know if anything can be improved. ☺️

[joshka]

Can you please suggest a simple and concise explanation of the bug?
If you're able, add it to the body of a commit message to make it automatically fill the changelog. If not, we can add the wording when squashing the commit.

[jan-ferdinand]

I have added an explanation of the bug and the fix to both the description of this PR and the commit message. Let me know should brevity be lacking, or if the level of detail could be improved upon (in either direction).

Also, I have reworked the part that @joshka had a nit about, without accepting the suggestion. If you prefer to have your suggestion exactly, I'll incorporate that instead.

[joshka]

Possible more brevity would be helpful (to avoid fatigue when reading a changelog), but what you have is also fine if you'd like it. Happy to merge as-is or take your changes if you want to put them.

Previously, when computing the inner rendering area of a block, all
titles were assumed to be positioned at the top, which caused the
height of the inner area to be miscalculated.

[jan-ferdinand]

Thanks for the shortened bug description as well as the improved code snippet. 👍 I've incorporated both and amended the PR accordingly.

[orhun]

Thanks for your contribution!

[jan-ferdinand]

Thanks for the guidance to get this merged smoothly. 🙂