feat(table): Add a Table::segment_size method #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
======================================
Coverage ? 90.9%
======================================
Files ? 42
Lines ? 12502
Branches ? 0
======================================
Hits ? 11373
Misses ? 1129
Partials ? 0 ☔ View full report in Codecov by Sentry. |
asomers
force-pushed
the
table.segment_size
branch
2 times, most recently
from
ed18445
to
3d2d451
Compare
joshka
requested changes
Dec 3, 2023
There was a problem hiding this comment.
LGTM - 1 small nit.
Can you please update the commit message (or provide one in a comment) that describes the behavior directly rather than in reference to Layout. This will end up in the Changelog, so think about how you'd announce the functionality rather than just describing the change and perhaps add 3 small code examples like
let area = Rect::new(0, 0, 62, 1);
let widths = [Min(10), Min(10, Min(10)];
// results in column widths 10, 10, 10
Table::new(rows).widths(widths).segment_size(SegmentSize::None);
// ...
asomers
force-pushed
the
table.segment_size
branch
from
3d2d451
to
69f73e4
Compare
|
BTW, for an example of this new feature in action, see asomers/ztop#33 . |
|
Does your CI process merge PRs with the main branch before running tests? Because the test that's failing is one that isn't in my branch. Neat, if true. |
Yep :) |
asomers
force-pushed
the
table.segment_size
branch
from
69f73e4
to
203e14f
Compare
|
Rebased. And I squashed my commits to satisfy the commit style checker. |
orhun
approved these changes
Dec 4, 2023
It controls how to distribute extra space to an underconstrained table. The default, legacy behavior is to leave the extra space unused. The new options are LastTakesRemainder which gets all space to the rightmost column that can used it, and EvenDistribution which divides it amongst all columns. Fixes ratatui-org#370
asomers
force-pushed
the
table.segment_size
branch
from
203e14f
to
70f7a11
Compare
joshka
approved these changes
Dec 4, 2023
joshka
added a commit
that referenced
this pull request
Jan 5, 2024
In #660 we introduced the segment_size field to the Table struct. However, we forgot to update the default() implementation to match the new() implementation. This meant that the default() implementation picked up SegmentSize::default() instead of SegmentSize::None. Additionally the introduction of Table::default() in an earlier PR, #339, was also missing the default for the column_spacing field (1). This commit fixes the default() implementation to match the new() implementation of these two fields by implementing the Default trait manually. BREAKING CHANGE: The default() implementation of Table now sets the column_spacing field to 1 and the segment_size field to SegmentSize::None. This will affect the rendering of a small amount of apps.
joshka
added a commit
that referenced
this pull request
Jan 5, 2024
In #660 we introduced the segment_size field to the Table struct. However, we forgot to update the default() implementation to match the new() implementation. This meant that the default() implementation picked up SegmentSize::default() instead of SegmentSize::None. Additionally the introduction of Table::default() in an earlier PR, #339, was also missing the default for the column_spacing field (1). This commit fixes the default() implementation to match the new() implementation of these two fields by implementing the Default trait manually. BREAKING CHANGE: The default() implementation of Table now sets the column_spacing field to 1 and the segment_size field to SegmentSize::None. This will affect the rendering of a small amount of apps.
Valentin271
pushed a commit
that referenced
this pull request
Jan 10, 2024
In #660 we introduced the segment_size field to the Table struct. However, we forgot to update the default() implementation to match the new() implementation. This meant that the default() implementation picked up SegmentSize::default() instead of SegmentSize::None. Additionally the introduction of Table::default() in an earlier PR, #339, was also missing the default for the column_spacing field (1). This commit fixes the default() implementation to match the new() implementation of these two fields by implementing the Default trait manually. BREAKING CHANGE: The default() implementation of Table now sets the column_spacing field to 1 and the segment_size field to SegmentSize::None. This will affect the rendering of a small amount of apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works just like Layout::segment_size, but for Tables. Previously, it was impossible to distribute extra space anywhere in a Table.
Fixes #370