fix: Render table with overflow #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeungKC
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=====================================
Coverage 90.9% 91.0%
=====================================
Files 42 42
Lines 12795 12808 +13
=====================================
+ Hits 11643 11656 +13
Misses 1152 1152 ☔ View full report in Codecov by Sentry. |
YeungKC
changed the title
YeungKC
changed the title
YeungKC
force-pushed
the
bugfix-overflow
branch
3 times, most recently
from
3b6f06b
to
7c16d33
Compare
YeungKC
force-pushed
the
bugfix-overflow
branch
from
7c16d33
to
df40caf
Compare
orhun
approved these changes
Dec 12, 2023
|
I'm not very know this lib, but I think, normally, only an empty string would trigger that issue. |
Valentin271
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I think that's enough test. I agree with @YeungKC, only an empty string, right aligned and with no border can trigger this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue in the
render_cellfunction that could lead to an index out of range error. The problem was caused by incorrect positioning of thexcoordinate in the original code.Fixes #684