Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use drain instead of remove in a loop #922

Merged
merged 2 commits into from
Feb 5, 2024
Merged

perf: Use drain instead of remove in a loop #922

merged 2 commits into from
Feb 5, 2024

Conversation

mo8it
Copy link
Contributor

@mo8it mo8it commented Feb 5, 2024

drain is more efficient than remove in a loop.

@mo8it mo8it changed the title Use drain instead of remove in a loop perf: Use drain instead of remove in a loop Feb 5, 2024
joshka
joshka approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshka joshka merged commit 0963463 into ratatui-org:main Feb 5, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@orhun orhun Awaiting requested review from orhun orhun is a code owner

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@kdheepak kdheepak Awaiting requested review from kdheepak kdheepak is a code owner

@Valentin271 Valentin271 Awaiting requested review from Valentin271 Valentin271 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mo8it @joshka