Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): highlight symbol when using a multi-bytes char #924

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(list): highlight symbol when using a multi-bytes char #924

merged 2 commits into from
Feb 5, 2024

Conversation

mrjackwills
Copy link
Contributor

ratatui v0.26.0 brought a regression in the List widget, in which the highlight symbol width was incorrectly calculated - specifically when the highlight symbol was a multi-char character, e.g. .

I have also added a single additional test to check the output when such a multi-byte char is used for the highlight symbol.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61a8278) 92.0% compared to head (863ffc3) 92.0%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #924   +/-   ##
=====================================
  Coverage   92.0%   92.0%           
=====================================
  Files         61      61           
  Lines      15493   15493           
=====================================
  Hits       14259   14259           
  Misses      1234    1234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdheepak
Copy link
Collaborator

kdheepak commented Feb 5, 2024

Nice find!

@Valentin271 Valentin271 merged commit 14c67fb into ratatui-org:main Feb 5, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants