perf(borders): allow border!() in const #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more compiler optimizations when the macro is used. Interestingly TOP | BOTTOM is bitwise or and not const (it's a trait…). insert is also not const, union is. Also moves tests from test folder to the file itself as I overlooked them initially. Borders was together in a file with Block back when it was introduced.
EdJoPaTo
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
=====================================
Coverage 91.9% 91.9%
=====================================
Files 61 61
Lines 15964 15992 +28
=====================================
+ Hits 14673 14701 +28
Misses 1291 1291 ☔ View full report in Codecov by Sentry. |
kdheepak
approved these changes
Mar 4, 2024
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
This allows more compiler optimizations when the macro is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more compiler optimizations when the macro is used.
Interestingly
TOP | BOTTOMis bitwise-or and notconst(as it's a trait…).insertis also notconst,unionis.Also moves tests from test folder to the file itself as I overlooked them initially. Borders was together in a file with Block back when it was introduced.
Also see #11 and #832