-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove pointless default on internal structs #980
Conversation
also remove other derives. They are unused and just slow down compilation.
Prefer None over some useless default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=====================================
Coverage 92.0% 92.0%
=====================================
Files 61 61
Lines 15933 15937 +4
=====================================
+ Hits 14660 14668 +8
+ Misses 1273 1269 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks good to me, thanks for this.
Had a little comment but it's non-blocking.
The abort should never be triggered as long as the code above is correct. An assertion checking the code above is correct is more useful then.
It might be a good idea to split the canvas changes from the rest of this PR as it has also changes to the code behavior? |
Surely I'm forgetting/misunderstanding something... Canvas doesn't have a change in behavior ..? |
The checks and math logic has changed. That might have changed something. It's not much so it could be fine to mix it. |
I think you might be referring to the Chart (not canvas) |
See ratatui-org#978 Also remove other derives. They are unused and just slow down compilation.
See #978
Also remove other derives. They are unused and just slow down compilation.