This repository has been archived by the owner on Sep 25, 2022. It is now read-only.
Cameragroup #33
Merged
Cameragroup #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 125
💛 - Coveralls |
|
@mohammadbashiri The tests are failing for Python 2.7 and 3.4. Looks like it's because of the @ symbol used for the dot product. Could you pleace change this to the numpy.dot() function or method? |
nickdelgrosso
suggested changes
Jun 9, 2018
|
Sorry, i did not see the message about the .egg file. I will change that too. |
nickdelgrosso
approved these changes
Jun 9, 2018
|
The single-case test for CameraGroup.look_at() worries me. I've added a test for Physical.look_at() to provide extra security for this method. @mohammadbashiri could you review and merge this Pull request: mohammadbashiri#1 Then we'll have more stability |
added test for Physical.look_at()
|
Great! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the CameraGroup class, with some tests. One thing to note is the test for the look_at methods of the child cameras of a CameraGroup instance. it works only for a special case of point coordinate (x=0, y=0, z=-1).