Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep alive support #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boenrobot
Copy link

@boenrobot boenrobot commented Apr 13, 2022

Added the ability to set up a keep alive interval that will close the connection if it does not receive a reply in time.

I've modeled the code largely after the one found in the ratchet server, except it's only monitoring the one connection the client is connected to, and the timer is returned, so that it can potentially be canceled later (or be replaced).

Help with adding tests will be appreciated, as I can't find any test that exchange messages over a real connection - just mock connections or mock connection creation.

EDIT: Commit updated to use my github email... Because I committed this from work, it originally used my work email. Oops.

@TheLevti
Copy link

Would be amazing to get this support out. I suspect I have such a case where sometimes the connection is just gone and I am stuck listening forever.

… connection if it does not receive a reply in time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants