064_builtins: clarify @addWithOverflow explanation #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were misunderstandings concerning overflowing operations and overflowed variables. Hopefully it's clearer now.
|
@DerTee Thank you so much for this. Sorry it took so long for me to get back to this. It's a great addition. |
vamega
pushed a commit
to vamega/ziglings
that referenced
this pull request
Jul 25, 2023
…arification 064_builtins: clarify @addWithOverflow explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were misunderstandings concerning overflowing operations and overflowed variables, see #94 for the discussion.
This PR is a draft for an explanation that is hopefully clearer.
I tried to keep the explanation relatively short, because I'm hoping that the direct relation to the code and variables is sufficient. That could be a mistake and probably needs feedback from users.
Also the user has one additional question to correct to make sure they understood the builtin (with the drawback of frustrating them if the explanation is still not clear enough -> meh). The main reason I added the question, was that reading a big chunk of text about overflow and not being asked a verifying question felt like a small let down.