Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing exercise. #304

Merged
merged 1 commit into from
May 14, 2023
Merged

Added testing exercise. #304

merged 1 commit into from
May 14, 2023

Conversation

chrboesch
Copy link
Collaborator

closes #277

@chrboesch
Copy link
Collaborator Author

chrboesch commented May 14, 2023

@perillo What does this error mean:

   +- RemoveDir /home/runner/work/ziglings/ziglings/zig-cache/tmp/cedb2d3eea8bc44c transitive failure
   |  +- check failure
   |     +- zig build -Dhealed success 1m MaxRSS:168M
   |        +- heal success
   |           +- case-2 cached

@chrboesch
Copy link
Collaborator Author

There is another hint:
check: error: 999_the_end.zig: expected to see "Compiling 999_the_end.zig...", found "PASSED:"

@chrboesch
Copy link
Collaborator Author

After the third run I get other errors:
zig build -Dhealed -Dn=94: error: the following command exited with code 2 (expected exited with code 0):

Weird.

@chrboesch
Copy link
Collaborator Author

Maybe it depends on #300

@chrboesch chrboesch merged commit 20a66aa into ratfactor:main May 14, 2023
8 of 11 checks passed
@chrboesch chrboesch deleted the testing_exercise branch May 14, 2023 23:00
@perillo
Copy link
Contributor

perillo commented May 15, 2023

There is another hint: check: error: 999_the_end.zig: expected to see "Compiling 999_the_end.zig...", found "PASSED:"

The cause is the new exercise 102, that confuses the CheckStep.
The solution is to update the tests.

@perillo
Copy link
Contributor

perillo commented May 15, 2023

After the third run I get other errors: zig build -Dhealed -Dn=94: error: the following command exited with code 2 (expected exited with code 0):

Weird.

I can not reproduce it. Can you tell me the error message?

@chrboesch
Copy link
Collaborator Author

Just run zig build test or take a look at: https://github.com/ratfactor/ziglings/actions/runs/4974676427/jobs/8901548287#step:4:15

@chrboesch
Copy link
Collaborator Author

The solution is to update the tests.

I already updated the tests. But as you can see in the github actions, there is no error on 102: https://github.com/ratfactor/ziglings/actions/runs/4974676427/jobs/8901548287#step:4:325

@perillo
Copy link
Contributor

perillo commented May 15, 2023

@chrboesch I have fixed the problem. I will create a PR later (with some changes in how testing is implemented)

@chrboesch
Copy link
Collaborator Author

I will create a PR later

ok

@perillo
Copy link
Contributor

perillo commented May 15, 2023

The solution is to update the tests.

I already updated the tests. But as you can see in the github actions, there is no error on 102: https://github.com/ratfactor/ziglings/actions/runs/4974676427/jobs/8901548287#step:4:325

The action log does not show the error
zig build -Dhealed -Dn=94: error: the following command exited with code 2 (expected exited with code 0):

and I was unable to reproduce it.

vamega pushed a commit to vamega/ziglings that referenced this pull request Jul 25, 2023
fleimgruber pushed a commit to fleimgruber/ziglings that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise 102 shall be for testing
2 participants