Improve compatibility for non-dry-contact configurations. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdraco Would you mind approving the workflows to run in this PR so I can ensure that the changes work in all of the tests in the CI matrix? Thanks. |
|
Been about a month ... any updates on this? I believe this would fix an issue I am having with a custom setup without dry-contacts |
|
I had been waiting for the CI results to ensure that the changes didn't break anything, and now I see they are all green, so I've marked this 'ready for review'. |
|
This looks ok to me. If I could not be on an airplane for a few days in a row (or the same time zone) I could test this. I only have one of the newer boards for testing and its been 1000s of miles away from where I've been at for the last few weeks |
|
@kpfleming Would you please resolve conflicts |
* Don't compile any dry-contact code unless PROTOCOL_DRYCONTACT is defined. * Use BinarySensor instead of GPIOBinarySensor to allow the user to use a template binary sensor (or any other type) if they wish.
|
Done. |
bdraco
approved these changes
Jul 3, 2024
bdraco
added a commit
that referenced
this pull request
Jul 3, 2024
All boards support dry contacts, the ifdefs are incorrect
bdraco
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't compile any dry-contact code unless PROTOCOL_DRYCONTACT is defined.
Use BinarySensor instead of GPIOBinarySensor to allow the user to use a template binary sensor (or any other type) if they wish. This is the recommendation of the ESPHome maintainers, and also aligns the C++ code with the Python configuration code (which will accept any type of binary sensor).
Closes #264.