-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for pre-releases in firmware update dialog #166
Conversation
Could this be added to the setting page? And then it is just on everywhere when it is checked? |
Also are we needing a new workflow so we can trigger pre-releases? |
Yes it could. But do we want the main page to alert users to pre-releases? Also, if I put it on the settings page then I need to have that setting saved at and retrieved from the server. Not a big deal. But we should decide on what the requirement is... I thought it was for testing purposes, rather than to announce and send out pre-releases/betas to all. |
Outside my area of expertise. But GitHub clearly supports it, and @thenewwazoo used the prerelease flag for early releases as I see it in the releases JSON returned. |
It could just be turned off by default, and then if they want prereleases they can. |
Yeah I can create another workflow for this. |
I'm not sure we are all on the same page here. I don't think we need a new workflow. All we need is for the ratgdo webUI to only look for builds tagged as releases. We can have a checkbox in the settings tab or in the update UI that says to also allow checking for new pre-release builds which is disabled by default. The whole idea here is so that I can do new builds and test them before everyone starts downloading and installing potentially broken builds like happened yesterday. the one change I wanted was for the workflow to skip the discord hook on a build tagged a pre-release. |
Okay @jgstroud, this is already in place so if we don't want it to publish for pre-release we can just remove that here: Latest: homekit-ratgdo/.github/workflows/release.yml Lines 192 to 202 in ccf6691
Prerelease: homekit-ratgdo/.github/workflows/release.yml Lines 203 to 214 in ccf6691
So as you can see it would add a prefix of |
User with chamberlain door ran into issue with rolling code not syncing properly.
The check for a new release on the main home page will NOT include check for pre-releases.
To check for pre-release you must open the firmware update dialog, select the checkbox, then click on the check for update button.
This way users are not notified of pre-releases automatically, but if you are in-the-know, you can check for and install them.