Remove the visibility check as it was causing issues. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkerr64
reviewed
May 2, 2024
There was a problem hiding this comment.
I think it okay to remove that. I checked the docs and it does warn that this function has limited availability, so may not work in all browsers.
https://developer.mozilla.org/en-US/docs/Web/API/Element/checkVisibility
can remove the setting to false and just have...
let prerelease = document.getElementById("prerelease").checked;
jgstroud
force-pushed
the
new_prerelease_check
branch
from
7b70251
to
682a565
Compare
|
Ugh... I need to quit rushing. I made the change you requested and didnt push it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dkerr64 This patch seem to be working