Enable adding multiple homekit-ratgdo's to HomeKit #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenewwazoo
reviewed
Dec 13, 2023
thenewwazoo
reviewed
Dec 13, 2023
Closed
thenewwazoo
reviewed
Dec 13, 2023
thenewwazoo
reviewed
Dec 13, 2023
Switch to snprintf. Use chipId for SERIAL_NUMBER. Rename to "Garage Door XXXXXX" Add unique HK device name from .getChipID()
Avi0n
force-pushed
the
enable-multiple-ratgdos
branch
from
41e6bfa
to
6204ed9
Compare
donavanbecker
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't possible to add more than one homekit-ratgdo device to HomeKit because
HOMEKIT_CHARACTERISTIC(NAME)was not unique. This change adds a unique name based onESP.getChipID()