Skip to content

Commit

Permalink
Follow up to d99c914
Browse files Browse the repository at this point in the history 
Thanks to @RadianFord and @CairoLee
  • Loading branch information
@Lemongrass3110
Lemongrass3110 committed Feb 4, 2017
1 parent 7377f0f commit 90e3f89
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions src/map/chrif.c
View file
Expand Up @@ -280,6 +280,7 @@ int chrif_isconnected(void) {
* Saves character data.
* @param sd: Player data
* @param flag: Save flag types:
* CSAVE_NORMAL: Normal save
* CSAVE_QUIT: Character is quitting
* CSAVE_CHANGE_MAPSERV: Character is changing map-servers
* CSAVE_AUTOTRADE: Character used @autotrade
Expand Down
12 changes: 6 additions & 6 deletions src/map/chrif.h
View file
Expand Up @@ -11,12 +11,12 @@
enum sd_state { ST_LOGIN, ST_LOGOUT, ST_MAPCHANGE };

enum e_chrif_save_opt {
CSAVE_NORMAL = 0x0, /// Normal
CSAVE_QUIT, /// Character quitting
CSAVE_CHANGE_MAPSERV, /// Character changing map server
CSAVE_AUTOTRADE, /// Character entering autotrade state
CSAVE_INVENTORY, /// Inventory data changed
CSAVE_CART, /// Cart data changed
CSAVE_NORMAL = 0x00, /// Normal
CSAVE_QUIT = 0x01, /// Character quitting
CSAVE_CHANGE_MAPSERV = 0x02, /// Character changing map server
CSAVE_AUTOTRADE = 0x04, /// Character entering autotrade state
CSAVE_INVENTORY = 0x08, /// Inventory data changed
CSAVE_CART = 0x10, /// Cart data changed
};

struct auth_node {
Expand Down

4 comments on commit 90e3f89

@RadianFord
Copy link
Contributor

@RadianFord RadianFord commented on 90e3f89 Feb 4, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got another issue regarding to this so it happened like this

  1. Wait till it saves the characters inventory etc..
  2. Try equipping another item.

then character got dc'ed and server keeps saying Server is still recognizes your last login

and here's the info

[Info]: auth_db: Node (state Map change) timed out for 2000000:150000
[Info]: User Count: 1 (Server: 0)
[Info]: clif_parse: Disconnecting session #8 with unknown packet version (p:0x0ee8,l:12).
[Info]: Closed connection from '***.***.***.***'.

Im using 2013-12-23cRagexe with this on

/// Comment to disable the official packet obfuscation support.
/// When enabled, make sure there is value for 'packet_keys' of used packet version or
/// defined 'packet_keys_use' in db/[import/]packet_db.txt.
/// This requires PACKETVER 2011-08-17 or newer.
#define PACKET_OBFUSCATION

and what i observed the server keeps saving the info of the character. even its not online

@Triedge
Copy link

@Triedge Triedge commented on 90e3f89 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this update cause double registration?
16506892_1284705024952372_1253110399_n

Today everything works normal and the moment it updates, everything started to fail.
The users connect, but soon they are expelled from the server.
But the server always marks that they are online.

@ilfan14
Copy link

@ilfan14 ilfan14 commented on 90e3f89 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with @RadianFord
if I return once before this Commit working normally.

@johnfercher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a related issue, after the update, I noticed that if I keep a char AFK, the mapserver crashes.
I tested on Windows and Linux, both have the same issue.

Please sign in to comment.