Skip to content

Commit

Permalink
Fixed the unknown packets on clients from october 2015 onwards
Browse files Browse the repository at this point in the history
Sorry guys, we actually created this issue ourselves, because we overwrote the data of the next incoming packet eventually.
Maybe this will make 2015-10-29 also useable again.

Fixes #1049.
  • Loading branch information
Lemongrass3110 committed Apr 17, 2016
1 parent 76922d8 commit f0aa0e5
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/map/clif.c
Expand Up @@ -9796,13 +9796,7 @@ static bool clif_process_message(struct map_session_data* sd, int format, char**
messagelen = textlen - NAME_LENGTH; // this should be the message length (w/ zero byte included)
}

#if PACKETVER >= 20151001
if (message[messagelen-1] != '\0')
{
message[messagelen++] = '\0';
}
#endif

#if PACKETVER < 20151001
// the declared length must match real length
if( messagelen != strnlen(message, messagelen)+1 ) {
ShowWarning("clif_process_message: Received malformed packet from player '%s' (length is incorrect)!\n", sd->status.name);
Expand All @@ -9814,6 +9808,7 @@ static bool clif_process_message(struct map_session_data* sd, int format, char**
ShowWarning("clif_process_message: Player '%s' sent an unterminated message string!\n", sd->status.name);
return false;
}
#endif

// messages mustn't be too long
if( messagelen > CHAT_SIZE_MAX-1 ) {
Expand Down

0 comments on commit f0aa0e5

Please sign in to comment.