Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magnum Break damage #108

Closed
Playtester opened this issue Nov 16, 2014 · 1 comment
Closed

Magnum Break damage #108

Playtester opened this issue Nov 16, 2014 · 1 comment
Assignees
@Playtester
Labels
component:skill A fault that deals specifically with a skill

Comments

@Playtester
Copy link
Member

I noticed when fighting Whispers on iRO that I couldn't use Magnum Breaks fire damage bonus to hit them. After investigating a bit, it seems the bonus is only applied if damage is at least 1 HP.

I also tested the damage in general and noticed that the damage formula is wrong. It only deals full damage to monsters in a 3x3 area around the user. Monsters in the 5x5 outer ring take less damage.

I researched a bit and found an in-depth description on a jRO wiki (http://mohige.sakura.ne.jp/knight/index.php?Job_Swordman). According to the wiki the damage is 100%+10%*level on the outer ring which fits to my tests.
@Playtester Playtester added the component:skill A fault that deals specifically with a skill label Nov 16, 2014
@Playtester Playtester self-assigned this Nov 16, 2014
Playtester added a commit that referenced this issue Nov 16, 2014
@Playtester
Magnum Break damage fixed
d9a9a02 
- The 20% fire damage bonus now only applies if the base damage is at least 1 (#108)
  (Note: The fix does not work for player damage in renewal.)
- Targets two cells away will now only take 100%+10%*level damage (#108)
@Playtester
Copy link
Member Author

Fixed in d9a9a02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Playtester Playtester

Labels
component:skill A fault that deals specifically with a skill
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Playtester