Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new script like pet <pet_id>; #2703

Closed
mjonrest opened this issue Dec 13, 2017 · 8 comments
Closed

new script like pet <pet_id>; #2703

mjonrest opened this issue Dec 13, 2017 · 8 comments

Comments

@mjonrest
Copy link

  • rAthena Hash:
  • Client Date:
  • Server Mode:
  • Description of Issue:

    • Result:
    • Expected Result:
    • How to Reproduce:
    • Official Information:
  • Modifications that may affect results:

can we have this kind of script, so we could catch many mob by using 1 taming item

by example:

unripe apple can catch poring or drops, or poporing

@Lemongrass3110 Lemongrass3110 added the status:invalid Issue that is either not official or is not related to rAthena label Dec 13, 2017
@Lemongrass3110 Lemongrass3110 removed the status:invalid Issue that is either not official or is not related to rAthena label Dec 13, 2017
@Lemongrass3110
Copy link
Member

Sorry I misread this issue.

@sader1992
Copy link
Contributor

sader1992 commented Dec 13, 2017

pet 0; well tame all the monsters in pet db
i don't know if this is a bug
i can't find the *pet command in the script.cpp

@aleos89
Copy link
Contributor

aleos89 commented Dec 13, 2017

	//catch_target_class == 0 is used for universal lures (except bosses for now). [Skotlex]
	if (sd->catch_target_class == 0 && !status_has_mode(&md->status,MD_STATUS_IMMUNE))
		sd->catch_target_class = md->mob_id;

Intended behavior.

@sader1992
Copy link
Contributor

@aleos89 thanks for the info!

@mjonrest
Copy link
Author

if i use pet 0; it will catch all mob in pet_db.. but how if we need to catch several mobs only.. can we add more command just like pet <pet_id>; command?

@aleos89
Copy link
Contributor

aleos89 commented Dec 15, 2017

@mjonrest : Honestly I haven't tried that. You could try specifying multiple mobs ie: pet 1001; pet 1002; and see how that works.

@mjonrest
Copy link
Author

#2705 fixed

@sader1992
Copy link
Contributor

sader1992 commented Dec 15, 2017

@aleos89 the problem with using { pet 1002; pet 1113; pet 1004; }
that Iit's only process the last command ,so in this example it will only catch 1004 and if you try it on 1002 and 1113 it will always fail

aleos89 pushed a commit that referenced this issue Dec 28, 2017
* Fixes #2703.
* Added alternative for script command bpet: birthpet.
* Added alternative for script command pet: catchpet.
* Updated documentation for script command pet.
* Added PET_CATCH_UNIVERSAL_ITEM for script command pet which will attempt to catch the targeted monster as long as it is in the pet database and the targeted monster requires the lure item used.
Thanks to @sader1992!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants