Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quest Skill Randomly Lost #277

Closed
uddevil opened this issue Feb 8, 2015 · 1 comment · Fixed by #287
Closed

Quest Skill Randomly Lost #277

uddevil opened this issue Feb 8, 2015 · 1 comment · Fixed by #287
Labels
component:core A fault that lies within the main framework of rAthena

Comments

@uddevil
Copy link
Contributor

uddevil commented Feb 8, 2015

So here's my problem, last commit that i used is this :
b43b855
(no big problem, working as intended)

Then i pull this one
90d9da1

And quest skills (such as Lord Exclamation, Cart Change, etc) are randomly lost when re-log, or using healer npc (the one with SC_START blablabla).

First i thought it was my customization that cause it, but then i tried again on my other server that has no customization at all (i'm only using custom npc from rA default like healer, reset, etc), but the skills keeps randomly lost everytime i logout. Lord exclamation was worse, it acts like scroll-based skills, one time usage then its lost.

So, i switch to this commit :
a427dbf

And all the problems are gone. Is it because of the skill db clean up?
@aleos89 aleos89 added the component:core A fault that lies within the main framework of rAthena label Feb 9, 2015
@aleos89
Copy link
Contributor

aleos89 commented Feb 9, 2015

This was my fault. I didn't mean to apply this when testing. Let me look back through this.

@cydh cydh added the started label Feb 10, 2015
cydh added a commit that referenced this issue Feb 12, 2015
@cydh
Skill DB clean ups
9d3d342 
* Changed skill_db array to better memory allocation.
* Reduced MAX_SKILL_LEVEL from 100 to 10 (part of Hercules HerculesWS/Hercules@0f4a50d), also has changes on skill_get checks for skill level that more than 10.
* Reduced MAX_SKILL from 5020 to 1200 (actually only 1109 skills are used).
* Added macros for checking Homunculus, Guild, Mercenary, & Elemental skill ranges.
* Added skill check & index validation when player logged in and when @reloadskilldb.
* Corrected `enum e_skill_flag` order for SKILL_FLAG_REPLACED_LV_0's sake.
* Merged 'addtoskill' script command just as alias of 'skill' script command.
* Fixed #277
* Changed 'skill' script command flag to constant value

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>

NOTE:
* Decreased memory usage by map-server reduced up to 50 MB.
* Decreased memory for each player because of mmo_charstatus::skill[] only has 1200 array, before is 5020.
* Please use skill_get_index() for accessing sd->status.skill[] or skill_db[], don't reckless use skill_id as array index.
* Please import upgrade_20150211_skillset.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
@cydh cydh mentioned this issue Feb 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up Skill DB rathena/rathena
3 participants
@aleos89 @cydh @uddevil