Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update my battleground script templates #3024

Closed
AnnieRuru opened this issue Apr 2, 2018 · 2 comments
Closed

update my battleground script templates #3024

AnnieRuru opened this issue Apr 2, 2018 · 2 comments
Labels
component:script A fault that lies within the scripts of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:enhancement Issue that is an enhancement to rAthena

Comments

@AnnieRuru
Copy link
Contributor

AnnieRuru commented Apr 2, 2018 •
edited

.... I just remove all the rubbish information then ...

I noticed rAthena now has its own updated battleground script commands
this also means my battleground script templates needs an update

I am lazy to make rAthena fork, so I just update this in paste
http://upaste.me/45a9495597107216b
http://upaste.me/712949560abb0683d

remember to review 1st before update it
reflecting the change made to this folder
https://github.com/rathena/rathena/tree/master/npc/custom/battleground
@secretdataz secretdataz mentioned this issue Apr 2, 2018
Merged
@aleos89 aleos89 added component:script A fault that lies within the scripts of rAthena priority:low A fault that affects rAthena in one piece of functionality and is self-contained mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:bug Issue that is a bug within rAthena labels Apr 2, 2018
@AnnieRuru
Copy link
Contributor Author

[type:bug] ?
nonono, the old version is also working fine actually,
or else Euphy wont get this script inside the emulator

it should be [type:enhancement]

@Lemongrass3110 Lemongrass3110 added type:enhancement Issue that is an enhancement to rAthena and removed type:bug Issue that is a bug within rAthena labels Apr 2, 2018
@Lemongrass3110
Copy link
Member

Fixed in e2b9e42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:script A fault that lies within the scripts of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:enhancement Issue that is an enhancement to rAthena
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lemongrass3110 @aleos89 @AnnieRuru