Cleaned up custom battleground scripts #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secretdataz
added
the
status:code-review
AnnieRuru
approved these changes
Apr 3, 2018
|
|
||
| // delay before match begins | ||
| sleep 6000; | ||
| mapannounce "bat_a01", "The rules are simple. The first team to break the opponent's Emperium wins!", bc_map; | ||
| sleep 3000; | ||
| for ( .@i = 5; .@i > 0; .@i-- ) { | ||
| for ( .@i = 5; .@i > 0; --.@i ) { |
There was a problem hiding this comment.
just want you guys to know why I did this
HerculesWS/Hercules#872
By the way, on an unrelated note, you might want to replace
.@i++with++.@i, since it's more efficient (the first one needs to cache the previous value of.@ito return it, while the second one doesn't)
* Turn the GvG flag off before setting the Battleground flag to avoid stack warning.
aleos89
approved these changes
Apr 9, 2018
|
Anything left to be done? |
|
I thought I look through the script over 5 times before I press the open issue button now this is interesting .... delwall should throw an error if the wall has never been set
|
3 tasks
See Hercules/Hercules#2017
Lemongrass3110
added
component:script
CrazyBS
pushed a commit
to CrazyBS/rathena
that referenced
this pull request
Apr 16, 2018
Added a warning to script command delwall
CrazyBS
added a commit
to CrazyBS/rathena
that referenced
this pull request
Apr 16, 2018
This reverts commit 8c0b52f.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue(s): update my battleground script templates #3024
Server Mode: Both
Description of Pull Request:
Cleaned up AnnieRuru's BG scripts.