Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PetDB loyal bonuses missing RC_Player bonuses where necessary #3937

Closed
Radio-Gagaa opened this issue Feb 10, 2019 · 0 comments
Closed

PetDB loyal bonuses missing RC_Player bonuses where necessary #3937

Radio-Gagaa opened this issue Feb 10, 2019 · 0 comments
Labels
component:database A fault that lies within the database of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena

Comments

@Radio-Gagaa
Copy link

  • Client Date: Irrelevant
  • Server Mode: Both
  • Description of Issue:
    • Result: Any Demi Human bonuses do not take effect on enemy players. Any bonuses that use RC_DemiHuman were not split up when RC_Player was introduced.
    • Expected Result: Pets that give RC_DemiHuman bonuses should also give RC_Player bonuses.
aleos89 added a commit that referenced this issue Feb 11, 2019
@aleos89
Corrected loyal pet bonuses
16e0a34 
* Fixes #3937.
* Added missing RC_Player bonuses.
Thanks to @indigo000!
@aleos89 aleos89 added component:database A fault that lies within the database of rAthena status:confirmed Issue that has been validated by a developer to affect rAthena priority:low A fault that affects rAthena in one piece of functionality and is self-contained mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:bug Issue that is a bug within rAthena labels Feb 11, 2019
@aleos89 aleos89 mentioned this issue Feb 11, 2019
Merged
@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:database A fault that lies within the database of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Radio-Gagaa @aleos89