Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed bonus3 bSPVanishRate #4016

Closed
Balferian opened this issue Mar 15, 2019 · 0 comments
Closed

Missed bonus3 bSPVanishRate #4016

Balferian opened this issue Mar 15, 2019 · 0 comments
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena

Comments

@Balferian
Copy link
Contributor

  • Client Date: -
  • Server Mode: Pre/Re

  • Description of Issue:

    • Result: bonus2 bSPVanishRate in Mental Destroyer (id 1661) working wrong, need update to bonus3 bSPVanishRate,x,n,bf. Now bonus work only for physical attack.
    • Expected Result: When player use magic skill on the target, sp of target should be vanished.
      Item script from Herc: <"
      bonus bInt, 10;
      bonus bUnbreakableWeapon, 0;
      bonus bUseSPrate, 100;
      bonus bMdef, 20;
      bonus3 bSPVanishRate, 1000, 5, BF_NORMAL | BF_SKILL;
      if (getrefine() >= 6) {
      bonus3 bSPVanishRate, 1000, 10, BF_NORMAL | BF_SKILL;
      }
      ">
    • How to Reproduce: attack other player on pvp map with Mental Destroyer (id 1661).
    • Official Information: Tested on kRo server (video)

  • Modifications that may affect results:
@aleos89 aleos89 added status:confirmed Issue that has been validated by a developer to affect rAthena component:core A fault that lies within the main framework of rAthena priority:low A fault that affects rAthena in one piece of functionality and is self-contained mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena labels Mar 19, 2019
aleos89 added a commit that referenced this issue Mar 21, 2019
@aleos89
Corrected Vellum and Vanish item bonuses
ce24795 
* Fixes #4016.
* Cleaned up the way Vellum damage and Vanish damage are calculated.
* Implemented bonus3 bSPVanishRate/bHPVanishRate.
* Updated Mental Destroyer item bonus.
* Cleaned up and added documentation.
Thanks to @Balferian!
@aleos89 aleos89 mentioned this issue Mar 21, 2019
Merged
@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleos89 @Balferian