Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update items Flags: DropEffect #5547

Closed
idk-whoami opened this issue Nov 16, 2020 · 3 comments · Fixed by #5563
Closed

update items Flags: DropEffect #5547

idk-whoami opened this issue Nov 16, 2020 · 3 comments · Fixed by #5563
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena

Comments

@idk-whoami
Copy link
Contributor

  • Client Date: 20200401
  • Server Mode: re
  • Description of Issue:
    rdata.grf 6 color
    rAthena 5 color
    Capture

บันทึก_2020_11_16_11_53_13_135

บันทึก_2020_11_16_11_53_33_767

บันทึก_2020_11_16_11_54_05_823

setting
` - Id: 501
AegisName: Red_Potion
Name: Red Potion
Type: Healing
Buy: 10
Weight: 70
Flags:
DropEffect: WHITE_PILLAR
Script: |
itemheal rand(45,65),0;

  • Id: 502
    AegisName: Orange_Potion
    Name: Orange Potion
    Type: Healing
    Buy: 50
    Weight: 100
    Flags:
    DropEffect: BLUE_PILLAR
    Script: |
    itemheal rand(105,145),0;
  • Id: 503
    AegisName: Yellow_Potion
    Name: Yellow Potion
    Type: Healing
    Buy: 180
    Weight: 130
    Flags:
    DropEffect: YELLOW_PILLAR
    Script: |
    itemheal rand(175,235),0;
  • Id: 504
    AegisName: White_Potion
    Name: White Potion
    Type: Healing
    Buy: 1200
    Weight: 150
    Flags:
    DropEffect: PURPLE_PILLAR
    Script: |
    itemheal rand(325,405),0;
  • Id: 505
    AegisName: Blue_Potion
    Name: Blue Potion
    Type: Healing
    Buy: 5000
    Weight: 150
    Flags:
    DropEffect: ORANGE_PILLAR
    Script: |
    itemheal 0,rand(40,60);
  • Id: 506
    AegisName: Green_Potion
    Name: Green Potion
    Type: Healing
    Buy: 40
    Weight: 70
    Flags:
    DropEffect: CLIENT
    BuyingStore: true
    Script: |
    sc_end SC_POISON; sc_end SC_SILENCE; sc_end SC_BLIND; sc_end SC_CONFUSION; sc_end SC_HALLUCINATION;`

https://github.com/rathena/rathena/blob/master/src/map/itemdb.hpp#L754-L764
/// Enum for item drop effects
enum e_item_drop_effect : uint16 {
DROPEFFECT_NONE = 0,
DROPEFFECT_CLIENT,
DROPEFFECT_WHITE_PILLAR,
DROPEFFECT_BLUE_PILLAR,
DROPEFFECT_YELLOW_PILLAR,
DROPEFFECT_PURPLE_PILLAR,
DROPEFFECT_ORANGE_PILLAR,
DROPEFFECT_MAX
};

  • Result:
  • Expected Result:
  • How to Reproduce:
  • Official Information:
  • Modifications that may affect results:
@Triedge
Copy link

Triedge commented Nov 16, 2020

this work with 2018 client?

@idk-whoami
Copy link
Contributor Author

i don't know with 2018 client

@Balferian
Copy link
Contributor

Pink droplight supported in iteminfo for all MVP cards.

[27109] = {
unidentifiedDisplayName = "지터벅 카드",
unidentifiedResourceName = "이름없는카드",
unidentifiedDescriptionName = { "감정되지 않음. [돋보기] 를 사용하여 감정할 수 있다." },
identifiedDisplayName = "지터벅 카드",
identifiedResourceName = "이름없는카드",
identifiedDescriptionName = {
"무속성 적에게 받는 물리, 마법 데미지 10% 감소.",
"MaxHP +500.",
"노래하는 페르, 연주하는 페르 카드와 함께 장착시, 물리, 마법 공격시 일정 확률로 6초 동안 각성한 페르로 변신.",
"각성한 페르로 변신시, HP를 2000만큼 회복하고 무속성 적에게 주는 물리, 마법 데미지 200% 증가.",
"계열 : ^777777카드^000000",
"장착 : ^777777투구^000000",
"무게 : ^7777771^000000",
"^B7B7B7[ID: 27109]^000000"
},
slotCount = 0,
ClassNum = 0,
costume = false,
EffectID = 1186
},

@aleos89 aleos89 added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained status:confirmed Issue that has been validated by a developer to affect rAthena type:bug Issue that is a bug within rAthena labels Nov 21, 2020
@Lemongrass3110 Lemongrass3110 linked a pull request Nov 21, 2020 that will close this issue
Lemongrass3110 added a commit that referenced this issue Nov 21, 2020
Fixes #5547

Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants