Updated Summoner class #1965

aleos89 · 2017-02-16T01:52:17Z

Addressed Issue(s): Adding support for the new doram skills #1865
Server Mode: Renewal
Description of Pull Request:
- Added the missing Summoner skills.
- Information based on kRO patch notes.
  - http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=1987966&curpage=1
- Updated previously implemented skills to better mimic official behavior.
  Thanks to @RagnarokNova, Fyrus, and Jet for their hard work on gathering the information!

TODO:

@RagnarokNova

* Added the missing Summoner skills. * Information based on kRO patch notes. - http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=1987966&curpage=1 * Fixes #1865. * Updated previously implemented skills to better mimic official behavior. Thanks to @RagnarokNova, Fyrus, and Jet for their hard work on gathering the information!

* Fixed a compile error in pre-renewal mode.

sigtus · 2017-02-21T16:29:26Z

Tested this. Have to change Lope target to self, or it doesn't work. Haven't found anything else yet.
It should be like this in skill_db.txt
5023,6:10:14,6,4,0,0x1,0,3,1,yes,0,0,0,none,0,0x0, SU_LOPE,Lope

feltenc · 2017-02-22T04:18:05Z

Hello Aleos! I am testing your PR on my sakray server, i have problems with the effects, its not implemented yet?

I am using 2016-03-16RagexeRE with rdata.grf and data.grf from kRO.

Skills like Hiss and Nyang Grass have effects and its not showing...

Ziu's Video: https://youtu.be/Bt5bYuxX6FA?t=182

iamferreirajp · 2017-02-22T05:01:50Z

got this error when compiling:
src\map\skill.c(11728): error C2196: case value '5027' already used

secretdataz · 2017-02-22T06:31:48Z

@iamferreirajp Did you merge your patch manually by hand? Because you that easily leads to compile and runtime errors if done incorrectly.

iamferreirajp · 2017-02-22T12:35:09Z

@secretdataz I did manually, but i fixed the error doing this //case SU_CN_POWDERING:

I don`t know why, but it seems that this skill was already declared on skill.c

iamferreirajp · 2017-02-22T12:37:08Z

By the way, do you guys have the data folder that make the skills appear on the skilltree? I've installed but i didn't change the data, therefore I can`t see the changes.

aleos89 · 2017-02-22T14:33:20Z

@feltenc: That is dependent upon the client. I don't think Gravity implemented all the effects until mid/late 2016.

@iamferreirajp: We don't. You can grab the kRO LUB info and translate it though.

feltenc · 2017-02-22T16:34:40Z

@aleos89 i will try on a 2017 hexed too and i come back to feedback ^~

@edit

effects working on 2017 clients.

feltenc · 2017-02-22T21:42:58Z

I upgraded my kRO and translated all skills directly from the kRO folder. So I'll try to do some reports to help with this pull request.

As we talked in Discord, here is a video of Ziu testing the skills, where he refers that the speed increase effect is almost the same as speed potion.
https://youtu.be/Bt5bYuxX6FA

*Grooming Skill

The Flee Increase is OK. But the "remove freeze, petrification, and so on" bonus is not working. Because I can not use the skill while frozen or petrified.

*Chattering Skill

The description says that the increase of ATK and MATK is not done in weapon / magic damage as you think, but directly in the bonus (alt + a).
Error show in the console

*Hiss Skill

The description says that it should be increased by +50 to the character's FLEE. It is increasing 5 only.

*Purring Skill

Okay, but needs to fix the grooming mov speed bonus.

*Meow Meow Skill

Only the ATK is being raised in the status window (alt + a), MATK is not modifying in the status window (alt + a).

*Power of Lock Skill

Always Missing
I think the effect chance is 100% cause it not mentioned any chances on the description... Only chance is mentioned is the "Certain Range" that is variable with the skill level.

*Tasty Shrimp Party Skill

I believe the effect duration is not correct (20 seconds at level 5). It lasts around 10 seconds only.
The user who used the skill is not receiving the "Bunch of Shrimp" buff as it says in the description.

*Nyang Grass Skill

-The first attack against the enemy on top of Nyang Grass is stronger, but the following magical attacks appear to have the same damage as if the character were outside the MDEF reduction area.
-The duration time at level 5 should be 10 seconds. By my calculations this lasts 8 seconds.

*Spirit of Savage Skill

It is not causing damage to enemies that are between the target and the caster.

These are my first tests, I hope it has helped, in case I have mistaken some translation, I apologize, but I am sure I have done the translation meticulously to avoid any misunderstanding.

As you yourself said @aleos89 still missing many adjustments (TODO) and hope to help as possible, any evaluation or test I will be available here to collaborate.

Grateful!

Felten.

aleos89 · 2017-02-23T18:17:28Z

Grooming: Fixed.
Chattering: Fixed (missing switch case which is why the bonuses weren't working) and upped the walk speed bonus from 30 to 50.
Hiss: This is working as intended. P. Dodge displayed on the client is a multiple of 10. (IE: 5 = 50)
Purring: Working as intended. It doesn't get a movement speed bonus (Grooming doesn't give this).
Meow Meow: Make sure your MATK damage changed via skills. It's just a visual display that it doesn't show.
Power of Flock: Will look into it. Make sure your targets are not immune to Fear/Freeze.
Tasty Shrimp Party: Fixed.
Spirit of Savage: Will look into it. Try to target things in a straight line for better results.

@feltenc

* Follow up to cca00dc. * Fixed Shrimp Party duration. * Fixed Shrimp Party Blessing not applying to caster. * Fixed Bunch of Shrimp and Spirit of Sea bonus duration check. * Fixed Chattering not casting properly. * Fixed Grooming not being able to cancel OPT1 statuses. * Adjusted the Spirit of Land, Hiss, and Chattering walk speed bonus to match Speed Potion. Thanks to @feltenc!

feltenc · 2017-02-27T02:44:00Z

Picky Peck Skill

Enemy with full HP

Enemy Lower HP - Less than 50%

The damage should be doubled.

@aleos89

@feltenc

* Fixed the HP check for Picky Peck's double damage bonus. Thanks to @feltenc!

feltenc · 2017-02-27T17:08:28Z

Hey aleos, thanks for the fix above.

Check the "Jump" skill of doram...

its not jumping on all maps type.

Grimfiend · 2017-02-27T20:29:29Z

Hi @aleos89
You're making a good job with the new Doram skills, thanks very much for that! ^^

Well, I'm testing the new skills in 2017-02-22aRagexeRE and the Root Twist skill have some bugs:

The ability causes the monster to lose focus on the player (it becomes passive again).
The ability makes the player always have an animation (I think this is because it tries to activate the SU_SV_ROOTTWIST_ATK ability)
Even after using the ability on the target, it is possible to use it on the same target even if the ability is still active on the target.
Damage is greater than 100.
A lot of error messages appear in the log.

Here an image of the error:

Thanks for all Aleos! xD

@edit:
The Lope skill stopped working as soon as it was changed to work together with the TK_HIGHJUMP. I would leave it as it was before and correct the effect of it that is not working very well.

aleos89 · 2017-02-27T22:28:22Z

About Silvervine Root Twist:

I think this is because the monster is stopped for so long that it can't reach it's target so it drops it.
I'll check it out.
This is official. The effect will "refresh" if casted on the target again.
I'll check it out.
I'll check it out.

About Lope:
I have a fix for it and will be pushing it shortly.

feltenc · 2017-03-03T02:48:41Z

The speed movement increase seems not working. Here i dont receive any mov increase.

With all skills that have mov speed bonus.

* Resolved the animation effects and attack type errors caused by Silvervine Root Twist. * Fixed Lope not jumping properly. -- Works like High Jump but based on click instead of look direction.

@feltenc

* Added the missing speed modification to status_calc_speed(). Thanks to @feltenc!

feltenc · 2017-03-04T22:17:57Z

Thanks @aleos89 . The movspeed bonus is now working like a charm. You can contact me on discord if you want more infos to fix Spirit of Savage(but i think the skill is self explanatory) and Power of Flock.

feltenc · 2017-03-06T05:42:12Z

The Soul Attack skill turns your basic attacks in ranged attacks. The character has a range of up to 15 cells to attack the enemy (basic attacks become ranged). In addition there is an addition in base attack. Status like STR seems to increase the damage of the doram's basic attack at a distance. The main thing we can confirm is that currently nothing happens to upar this ability, so I think the main thing is to make the effect bigger to work, that is, to have the character attack from a distance.

@feltenc

* Fixed Soul Attack not increasing the player's melee range. Thanks to @feltenc!

feltenc · 2017-03-07T20:03:47Z

Thanks Aleos, the ranged attacks works like a charm. The only point now is: The "attack effect" is not showing. The attack animation is the same.

@feltenc

* Fixed Power of Flock not activating Fear and Frozen on enemies. * Fixed Spirit of Savage not dealing damage to enemies between the user and the target. Thanks to @feltenc!

* SP consumption reduced from 30 to 10. * No longer consumes SP when canceling Hide. * From kRO April 5, 2017 patch.

aleos89 · 2017-04-28T17:54:23Z

@HaloLVP : That's the intended behavior of those two skills.

@feltenc

* Fixed a Power of Sea combo check (Follow up to 541b065). * Fixed Spirit of Life bonus formula. * Tuna Belly now works on targets with Berserk. * Tuna Belly will now show a 0 heal value when HP is full. Thanks to @feltenc and @Atemo!

Atemo · 2017-05-02T21:39:22Z

Scratch bleed success rate

Scratch lvl 1 : 80%
Scratch lvl 2 : 90%
Scratch lvl 3 : 100%

(chance lowered by agi target)

@Atemo

* Updated success rate to skill level * 10 + 70%. * Corrected duration to be 120 seconds. Thanks to @Atemo!

sikiro · 2017-05-03T15:07:41Z

@feltenc what translations are you using? i want to test these skills and give feedback but english luas do not have the advance skills for doram?

* Follow up to 857f1d1. * Added back the removed cooldown.

sikiro · 2017-05-11T02:55:55Z

have these been tested on 2015 client? 20151104 i am aware of the possible no skill effect but do they work on this client.

Mikegyver · 2017-05-11T03:16:57Z

try to grab these lua files & put into ur skillinfoz folder inside ur grf

https://github.com/zackdreaver/ROenglishRE/tree/master/data/luafiles514/lua%20files/skillinfoz/RebellionRE

it not works for those expanded summoner skills with 2015-11-04aRagexe Client. below are the screenshots..

Atemo · 2017-05-26T18:44:22Z

Reflect shield should reflect a part of SU_SV_ROOTTWIST_ATK dmg. (ie reflect shield lvl 5 reflect 25 dmg / 100)

Felleonel · 2017-06-04T03:01:45Z

Silvervine Root Twist cause a rude bug position when a player moves with skills like Charge Attack, Cicada Skin Shed, Illusion-Shadow (Zanzou), Illusion-Bewitch (Genwaku) and etc.

sanny1128 · 2017-06-07T14:19:16Z

the skill Power of Land have some issue
when hit by long or magic attack and hurt damage>0 will autospell Silvervine Stem Spear if learn Power of Land after use Catnip Meteor

but attack someone(mob or player) it will autospell Silvervine Stem after use Catnip Meteor NOW!

Lemongrass3110

A few minor things. doc/status_change.txt needs to be updated.

Lemongrass3110 · 2017-07-03T16:45:48Z

src/map/skill.c

 				if (item_idx >= 0) {
 					pc_delitem(sd, item_idx, 1, 0, 1, LOG_TYPE_CONSUME);
 					flag |= 1;
 				}
+				if (sd && pc_checkskill(sd, SU_SPIRITOFLAND))


sd was checked 7 lines above this

Lemongrass3110 · 2017-07-03T16:51:23Z

src/map/status.c

@@ -4377,6 +4395,7 @@ int status_calc_npc_(struct npc_data *nd, enum e_status_calc_opt opt)
 void status_calc_regen(struct block_list *bl, struct status_data *status, struct regen_data *regen)
 {
 	struct map_session_data *sd;
+	struct status_change *sc = status_get_sc(bl);


Move this into the sd check in line 4404

Lemongrass3110 · 2017-07-03T16:57:31Z

src/map/status.c

+					val2 += min + rnd() % (max - min) + 178; // Heal
+				else
+					val2 += min + 178; // Heal
+


val2 += min + 178; if( max > min ) val2 += rnd() % (max-min);

Lemongrass3110 · 2017-07-03T17:01:30Z

src/map/unit.c


 	nullpo_retr(false,bl);

 	sd = BL_CAST(BL_PC, bl);
 	ud = unit_bl2ud(bl);
+	sc = status_get_sc(bl);


sd & sc could both be moved down a little

@Atemo

* It is now a MISC attack type. * The skill's damage is now able to be reflected to the caster. * Corrected some visualization issues. Thanks to @Atemo and @Lemongrass3110!

@Lemongrass3110

* Minor cleanups and adjustments. * Added documentation for Summoner status changes. Thanks to @Lemongrass3110!

* Minor improvements to processing when checking for valid data.

Hit all points!

@Felleonel

* Fixes an issue where position changing skills would update the Root Twisted player's new position on the server but not update the client causing a desync. Thanks to @Felleonel!

@sanny1128

* Fixed Catnip Meteor and Spirit of Land combo bonus (Silvervine Stem Spear) checks. * The combo should now cast Silvervine Stem Spear based on the caster's learned level. Thanks to @sanny1128!

aleos89 added mode:renewal A fault that exists within the renewal mode server:map status:code-review Pull Request that requires reviewing from other developers before being pushed to master status:need more info Issue that needs more information from a creditable source labels Feb 16, 2017

Follow up to cca00dc

bb5475f

* Fixed a compile error in pre-renewal mode.

Corrected Picky Peck double damage bonus

ba4e1ea

* Fixed the HP check for Picky Peck's double damage bonus. Thanks to @feltenc!

aleos89 added 2 commits March 3, 2017 16:55

Corrected Silvervine Root Twist and Lope

1ec8b24

* Resolved the animation effects and attack type errors caused by Silvervine Root Twist. * Fixed Lope not jumping properly. -- Works like High Jump but based on click instead of look direction.

Fixed the walkspeed bonus from some skills

a77f74a

* Added the missing speed modification to status_calc_speed(). Thanks to @feltenc!

Corrected Soul Attack range bonus

4563cdc

* Fixed Soul Attack not increasing the player's melee range. Thanks to @feltenc!

Corrected Power of Flock and Spirit of Savage

4289e66

* Fixed Power of Flock not activating Fear and Frozen on enemies. * Fixed Spirit of Savage not dealing damage to enemies between the user and the target. Thanks to @feltenc!

Updated Summoner Hide

74bdf3b

* SP consumption reduced from 30 to 10. * No longer consumes SP when canceling Hide. * From kRO April 5, 2017 patch.

Corrected a few Summoner skills

d1fbba6

* Fixed a Power of Sea combo check (Follow up to 541b065). * Fixed Spirit of Life bonus formula. * Tuna Belly now works on targets with Berserk. * Tuna Belly will now show a 0 heal value when HP is full. Thanks to @feltenc and @Atemo!

Updated Scratch skill

857f1d1

* Updated success rate to skill level * 10 + 70%. * Corrected duration to be 120 seconds. Thanks to @Atemo!

Updated Scratch skill

cf8f701

* Follow up to 857f1d1. * Added back the removed cooldown.

Mikegyver mentioned this pull request May 9, 2017

missing summoner expanded skills in skill tree window zackdreaver/ROenglishRE#18

Closed

aleos89 added component:skill A fault that deals specifically with a skill priority:low A fault that affects rAthena in one piece of functionality and is self-contained labels Jun 22, 2017

aleos89 added 3 commits June 22, 2017 12:57

Merge branch 'master' into update/summoner_expanded

0074747

Merge branch 'master' into update/summoner_expanded

cdc46e5

Merge branch 'master' into update/summoner_expanded

8af14b6

Lemongrass3110 previously requested changes Jul 3, 2017

View reviewed changes

aleos89 added 3 commits July 3, 2017 18:27

Updated Silvervine Root Twist

aee82f1

* It is now a MISC attack type. * The skill's damage is now able to be reflected to the caster. * Corrected some visualization issues. Thanks to @Atemo and @Lemongrass3110!

Minor updates

27d6268

* Minor cleanups and adjustments. * Added documentation for Summoner status changes. Thanks to @Lemongrass3110!

Follow up to 27d6268

648f668

* Minor improvements to processing when checking for valid data.

aleos89 added 2 commits July 5, 2017 17:55

Resolved a desync issue for Silvervine Root Twist

4ae913d

* Fixes an issue where position changing skills would update the Root Twisted player's new position on the server but not update the client causing a desync. Thanks to @Felleonel!

Fixed a Spirit of Land bonus

21f22f4

* Fixed Catnip Meteor and Spirit of Land combo bonus (Silvervine Stem Spear) checks. * The combo should now cast Silvervine Stem Spear based on the caster's learned level. Thanks to @sanny1128!

aleos89 merged commit 5f7a143 into master Jul 5, 2017

aleos89 deleted the update/summoner_expanded branch July 5, 2017 23:40

aleos89 removed status:need more info Issue that needs more information from a creditable source status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Jul 5, 2017

aleos89 mentioned this pull request Jul 5, 2017

Summoner skills missing information #2239

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Summoner class #1965

Updated Summoner class #1965

aleos89 commented Feb 16, 2017 •

edited

Loading

sigtus commented Feb 21, 2017

feltenc commented Feb 22, 2017 •

edited

Loading

iamferreirajp commented Feb 22, 2017

secretdataz commented Feb 22, 2017

iamferreirajp commented Feb 22, 2017

iamferreirajp commented Feb 22, 2017 •

edited

Loading

aleos89 commented Feb 22, 2017

feltenc commented Feb 22, 2017 •

edited

Loading

feltenc commented Feb 22, 2017

aleos89 commented Feb 23, 2017 •

edited

Loading

feltenc commented Feb 27, 2017

feltenc commented Feb 27, 2017

Grimfiend commented Feb 27, 2017 •

edited

Loading

aleos89 commented Feb 27, 2017 •

edited

Loading

feltenc commented Mar 3, 2017 •

edited

Loading

feltenc commented Mar 4, 2017

feltenc commented Mar 6, 2017 •

edited

Loading

feltenc commented Mar 7, 2017

aleos89 commented Apr 28, 2017

Atemo commented May 2, 2017

sikiro commented May 3, 2017

sikiro commented May 11, 2017

Mikegyver commented May 11, 2017

Atemo commented May 26, 2017 •

edited

Loading

Felleonel commented Jun 4, 2017

sanny1128 commented Jun 7, 2017

Lemongrass3110 left a comment

Lemongrass3110 Jul 3, 2017

Lemongrass3110 Jul 3, 2017

Lemongrass3110 Jul 3, 2017

Lemongrass3110 Jul 3, 2017

Updated Summoner class #1965

Updated Summoner class #1965

Conversation

aleos89 commented Feb 16, 2017 • edited Loading

sigtus commented Feb 21, 2017

feltenc commented Feb 22, 2017 • edited Loading

iamferreirajp commented Feb 22, 2017

secretdataz commented Feb 22, 2017

iamferreirajp commented Feb 22, 2017

iamferreirajp commented Feb 22, 2017 • edited Loading

aleos89 commented Feb 22, 2017

feltenc commented Feb 22, 2017 • edited Loading

feltenc commented Feb 22, 2017

aleos89 commented Feb 23, 2017 • edited Loading

feltenc commented Feb 27, 2017

feltenc commented Feb 27, 2017

Grimfiend commented Feb 27, 2017 • edited Loading

aleos89 commented Feb 27, 2017 • edited Loading

feltenc commented Mar 3, 2017 • edited Loading

feltenc commented Mar 4, 2017

feltenc commented Mar 6, 2017 • edited Loading

feltenc commented Mar 7, 2017

aleos89 commented Apr 28, 2017

Atemo commented May 2, 2017

sikiro commented May 3, 2017

sikiro commented May 11, 2017

Mikegyver commented May 11, 2017

Atemo commented May 26, 2017 • edited Loading

Felleonel commented Jun 4, 2017

sanny1128 commented Jun 7, 2017

Lemongrass3110 left a comment

Choose a reason for hiding this comment

Lemongrass3110 Jul 3, 2017

Choose a reason for hiding this comment

Lemongrass3110 Jul 3, 2017

Choose a reason for hiding this comment

Lemongrass3110 Jul 3, 2017

Choose a reason for hiding this comment

Lemongrass3110 Jul 3, 2017

Choose a reason for hiding this comment

aleos89 commented Feb 16, 2017 •

edited

Loading

feltenc commented Feb 22, 2017 •

edited

Loading

iamferreirajp commented Feb 22, 2017 •

edited

Loading

feltenc commented Feb 22, 2017 •

edited

Loading

aleos89 commented Feb 23, 2017 •

edited

Loading

Grimfiend commented Feb 27, 2017 •

edited

Loading

aleos89 commented Feb 27, 2017 •

edited

Loading

feltenc commented Mar 3, 2017 •

edited

Loading

feltenc commented Mar 6, 2017 •

edited

Loading

Atemo commented May 26, 2017 •

edited

Loading