Expanded bg_get_data script command #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now able accept type parameter of 1 to list account IDs of battleground members. Originally implemented by @AnnieRuru at https://rathena.org/board/topic/72571-b/
aleos89
approved these changes
Jun 1, 2017
Lemongrass3110
previously requested changes
Jun 6, 2017
doc/script_commands.txt
Outdated
| @@ -8863,6 +8863,8 @@ Example: | |||
| Retrieves data related to given Battle Group. Type can be one of the following: | |||
|
|
|||
| 0 - Amount of players currently belonging to the group. | |||
| 1 - Store GID of players in <Battle Group> in a temporary global array $@arenamembers | |||
There was a problem hiding this comment.
Adjust the indentation to match the 0 parameter please. Either both tabs or both blanks.
src/map/script.c
Outdated
| case 1: | ||
| for (i = 0; bg->members[i].sd != NULL; i++) | ||
| mapreg_setreg(reference_uid(add_str("$@arenamembers"), i), bg->members[i].sd->bl.id); | ||
| mapreg_setreg(reference_uid(add_str("$@arenamemberscount"), i), i); |
There was a problem hiding this comment.
Like this it will create an array for arenamembercount and will put the actual count value at index i.
See getpartymember: mapreg_setreg(add_str("$@partymembercount"),j);
* Corrected some documentation style. * Adjusted $@partymembercount to be stored as an integer and not an array. Thanks to @Lemongrass3110!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue(s): None
Server Mode: Both
Description of Pull Request:
Allows GID of players in certain battleground to be retrieved via the script engine by expanding
bg_get_datascript command.