Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for RODEX 2017 #2290

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Added support for RODEX 2017 #2290

merged 2 commits into from
Jul 27, 2017

Conversation

Lemongrass3110
Copy link
Member

  • Addressed Issue(s): None
  • Server Mode: Both
  • Description of Pull Request:
    Adds support for the 2017 version of RODEX.
    Thanks to everyone that donated towards the feature goal. 👍

@Lemongrass3110 Lemongrass3110 added mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode server:map status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Jul 26, 2017
@Mikegyver
Copy link
Contributor

Finally.. the kraken is released. Heh. xD

@Lemongrass3110
Copy link
Member Author

One of the krakens :-P
Another one is about to emerge soon as well. :-)

@Mikegyver
Copy link
Contributor

I think rodex 2017 was released by gravity on 2017-04-19bRagexeRE client.

@aleos89
Adjusted RODEX 2017 supported client date
c3a4aab 
* Adjusted date to 2017-04-19.
Thanks to @hazimjauhari90!
Mikegyver
Mikegyver reviewed Jul 27, 2017
View reviewed changes
Copy link
Contributor

@Mikegyver Mikegyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be now working on both 2017-03-29 RE client (which using older rodex, 2015) & 2017-05-17 (which using new rodex, 2017)

Akkarinage
Akkarinage approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@Akkarinage Akkarinage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on 2017-06-7cRagexeRE

@admkakaroto
Copy link
Contributor

Working fine on 2017-05-31bRagexeRE

@ghost
Copy link

ghost commented Jul 27, 2017

Working fine on 2017-06-14bRagexeRE

@Lemongrass3110
Copy link
Member Author

Working fine on 2017-06-28bRagexeRE as well :-)

@Lemongrass3110 Lemongrass3110 merged commit 02135c4 into master Jul 27, 2017
@Lemongrass3110 Lemongrass3110 deleted the feature/rodex2017 branch July 27, 2017 19:52
@aleos89 aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikegyver Mikegyver Mikegyver left review comments

@Akkarinage Akkarinage Akkarinage approved these changes

Assignees
No one assigned
Labels
mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lemongrass3110 @Mikegyver @admkakaroto @Akkarinage @aleos89