Emoticons constant name #2527
Emoticons constant name #2527
Conversation
… client side. * Note: the previous emoticons names are now deprecated. Additionally target use UNITTYPE_NPC and UNITTYPE_PC constants to specify the emotion target. * Note: previously the value of the parameter "target" for npc was 0. UNITTYPE_NPC value is 1.
This comment was marked as abuse.
This comment was marked as abuse.
|
@Anacondaqq the main part of the codebase should be covered by this pull request. The rest should be easy for each serverowner to find, because the script engine will report deprecated constant usage as soon as you load the script. |
Lemongrass3110
added
component:core
src/map/script.cpp
Outdated
| @@ -12700,36 +12700,42 @@ BUILDIN_FUNC(gvgoff3) | |||
|
|
|||
| /*========================================== | |||
| * Shows an emoticon on top of the player/npc | |||
| * emotion emotion#, <target: 0 - NPC, 1 - PC>, <NPC/PC name> | |||
| * emotion emotion#, <target: UNITTYPE_NPC (1) - NPC, UNITTYPE_PC (0) - PC>, <NPC/PC name> | |||
There was a problem hiding this comment.
Remove the numbers please. Users should never use the values behind the constants.
| @@ -18500,7 +18506,12 @@ BUILDIN_FUNC(unitemote) | |||
|
|
|||
| emotion = script_getnum(st,3); | |||
|
|
|||
| if(script_rid2bl(2,bl)) | |||
There was a problem hiding this comment.
Please edit comment /// @see e_* in db/const.txt above this command.
* Corrected the encodage for cutin as well in quests_moscovia
* Now accepts the game ID rather than the object name. * Removed the UNITTYPE_* parameter. * Deprecated script command unitemote. * Updated all NPC to reflect this new format. * Fixed all ET_KIK -> ET_KEK.
* Updated some remaining NPC.
* Reverted ET_KIK -> ET_KEK change * Corrected emotion character game ID * Reverted some emotion NPC target (for duplicates NPCs) * Fixed incorrect variable in quests_brasilis.txt (thanks to @Lemongrass3110 !)
aleos89
removed
the
status:code-review
|
can you give list change for example hmm to scratch, omg to huk this will help people to find and replace the custom NPC thx |
|
edited, i find it from your link sir @cydh thx very much ^^ |
|
Helo cydh can i set the emoticons deprecated to true, true? the old emoticon will be working? |
|
Aww changing syntax and constant? Will need to convert every emotion line by line now then@@ |
This comment was marked as abuse.
This comment was marked as abuse.
|
finaly i was finished change one by one by using notepad++ use find syntax emotion :D |
|
@Anacondaqq Yeah there is ton. I use alot in my script. Since not just changing the constant but also the syntax. And because previously the 2rd param are for attached player and now it no more so can't just replace all with notepad++ since it might not be same behavior like before. |
|
Should also update the warning message? Since some don't even show the file name. |
|
https://github.com/rathena/rathena/blob/master/tools/convert_emotions.py Wrote a small conversion script. (But I didn't test the outcoming NPCs). Leave me feedback if anything is missing. Edit: |
|
if run script conversion @Jeybla what about line this ea88ea5#diff-d5e39e5b7e19d8ad064b046e03d14af2R2713 are this line also will be replaced? |
|
I bump this because the converter is not working |
|
@M45T3Ryu please open an issue |
Addressed Issue(s): None
Server Mode: Renewal and Pre-renewal
Description of Pull Request:
This PR change the emoticons constant name to match emoticonlist from client side.
Note: the previous emoticons names are now deprecated.