Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved enchants not executing unequip script #2676

Merged
merged 2 commits into from Dec 15, 2017
Merged

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Dec 4, 2017

  • Addressed Issue(s): Bug - Enchant bonus #2668

  • Server Mode: Pre-renewal and Renewal

  • Description of Pull Request:

    • Fixes enchant items not properly calling the unequip item script.
    • Added a status calculation check when equipping combo items.
      Thanks to @admkakaroto and @mrjnumber1!

* Fixes #2668.
* Fixes enchant items not properly calling the unequip item script.
* Added a status calculation check when equipping combo items.
Thanks to @admkakaroto and @mrjnumber1!
@aleos89 aleos89 added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Dec 4, 2017
@admkakaroto
Copy link
Contributor

nice work!

@admkakaroto
Copy link
Contributor

admkakaroto commented Dec 5, 2017

@aleos89
I found a problem, when you equip any item that uses 'hateffect' in the script, it does not activate immediately, you need to do any modification of status for the effect to appear, I have not tested with the script for other items yet.

* Reverted the status calculation check when equipping combo items.
@aleos89 aleos89 merged commit b3e67d2 into master Dec 15, 2017
@aleos89 aleos89 deleted the hotfix/issue2668 branch December 15, 2017 19:29
@aleos89 aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants