Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for clients up to 2018-03-07bRagexeRE #2975

Merged
merged 5 commits into from Mar 14, 2018
Merged

Added support for clients up to 2018-03-07bRagexeRE #2975

merged 5 commits into from Mar 14, 2018

Conversation

Lemongrass3110
Copy link
Member

  • Addressed Issue(s): None
  • Server Mode: Both
  • Description of Pull Request:
    Adds support for:
    • 2018-02-21aRagexeRE
    • 2018-02-21bRagexeRE
    • 2018-03-07bRagexeRE

@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena labels Mar 11, 2018
@admkakaroto
Copy link
Contributor

Support this? HerculesWS/Hercules#1990

@idamonli
Copy link

idamonli commented Mar 12, 2018 •
edited

bg_quest1

2018-03-07bRagexeRE
New UI for QUEST system
system\OngoingQuestInfoList.lub
New packets need to be added
"setquest" makes the script unoperable and the player unable to move
This problem has arisen in previous versions of ZERO
HerculesWS/Hercules#1960
and
Attendance system HerculesWS/Hercules#1990

@Lemongrass3110
Added support for quest packets V3
6b966ec 
Credits to @dastgir and the leaked 2015 dump.
@Lemongrass3110
Copy link
Member Author

@idamonli quests should be working now.
Would be nice if you could test it and give me some feedback.

@Lemongrass3110
Copy link
Member Author

@admkakaroto not yet. Probably will be another pull request.

@idamonli
Copy link

Really don't have red mask

@Lemongrass3110
Copy link
Member Author

@Asheraf @4144 the last commit might be interesting for you guys.

@idamonli
Copy link

Cannot be used at present:
The pet system evolution
Equipment combination
and
HerculesWS/Hercules#1990

You can add? If possible.

@Lemongrass3110
Copy link
Member Author

Dont get carried away please. :-)

@idamonli
Copy link

idamonli commented Mar 14, 2018 •
edited

Here's the icon, great
quest2

@Lemongrass3110 Lemongrass3110 merged commit f338d53 into master Mar 14, 2018
@Lemongrass3110 Lemongrass3110 deleted the feature/clients-2018-02 branch March 14, 2018 22:05
@aleos89 aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Mar 15, 2018
sctnightcore
sctnightcore reviewed Mar 17, 2018
View reviewed changes
src/map/clif_packetdb.hpp
@@ -2353,4 +2358,23 @@
packet(0x0ACC,18);
#endif

// 2018-02-07bRagexeRE
#if PACKETVER >= 20180207
parseable_packet(0x0AF4,11,clif_parse_UseSkillToPos,2,4,6,8,10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not like clif_parse_UseSkillToPos in shuffle?
check in Herc dont have it .

CrazyBS pushed a commit to CrazyBS/rathena that referenced this pull request Apr 16, 2018
@Lemongrass3110 @CrazyBS
Added support for clients up to 2018-03-07bRagexeRE (rathena#2975)
998af58 
Thanks to @4144 as always
Credits to @dastgir and the leaked 2015 dump for the quest packets
Thanks to @idamonli for testing and feedback
CrazyBS added a commit to CrazyBS/rathena that referenced this pull request Apr 16, 2018
@CrazyBS
Revert "Added support for clients up to 2018-03-07bRagexeRE (rathena#…
354621b 
…2975)"

This reverts commit 998af58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sctnightcore sctnightcore sctnightcore left review comments

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lemongrass3110 @admkakaroto @idamonli @sctnightcore @aleos89