Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcblockall command. #3209

Closed
wants to merge 5 commits into from
Closed

pcblockall command. #3209

wants to merge 5 commits into from

Conversation

crazy-arashi
Copy link
Contributor

Block players action same like opening a mes box.

  • Addressed Issue(s):
    None.
  • Server Mode:
    Both.
  • Description of Pull Request:
    A script command for simulating the mes box.
    I believe this is useful for the upcoming episode updates.
    Credits mainly to joecalis of rathena, just added some parts to it.

Block players action same like opening a mes box.
@secretdataz
Copy link
Member

I'd rework existing pcblockxxx commands to use some kind of bit flags instead of adding an or in the condition of `if(blockedx || blockedall).
I don't think we need this addition right now.

@crazy-arashi
Copy link
Contributor Author

okie, just got the idea when I tested the recent morse cave instance.

@anacondaq

This comment was marked as abuse.

@hurtsky
Copy link

hurtsky commented Jun 16, 2018

@Anacondaqq i believe sir @secretdataz wanted to do something like hercules do

PCBLOCK_NONE 
PCBLOCK_MOVE 
PCBLOCK_ATTACK
PCBLOCK_SKILL
PCBLOCK_USEITEM 
PCBLOCK_CHAT
PCBLOCK_IMMUNE
PCBLOCK_SITSTAND
PCBLOCK_COMMANDS 
PCBLOCK_NPCCLICK
PCBLOCK_ALL

@Atemo
Copy link
Contributor

Atemo commented Jun 18, 2018

Block players action same like opening a mes box.

Additionnally this action could be enabled by default when a player is attached to a script, like in official server (with battle config for disclaimer).

@cydh
Copy link
Contributor

cydh commented Jun 18, 2018

Additionnally this action could be enabled by default when a player is attached to a script, like in official server (with battle config for disclaimer).

@Atemo I prefer with another calling/naming and how it works, just like disable_items, enable_items and its config. to avoid overlap from this pcblockall actual purpose (even idk the implementation, maybe for some games to freeze everyone?)

edit, dem typos

@crazy-arashi
Copy link
Contributor Author

Recently in the jRO's episode updates it completely stops the players action when activating an event. I'm not sure if kRO is the same since i don't have access to it. I think it's good temporarily and improve it later on for more versatility.

@Atemo
Copy link
Contributor

Atemo commented Feb 18, 2019

#3951 since the branch has been deleted.

@Atemo Atemo closed this Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants