Initial release of Sky Fortress Invasion Instance (Official Conversion) #3586

Atemo · 2018-10-16T22:00:49Z

Addressed Issue(s): -

Server Mode: renewal

Description of Pull Request:
TODO

Implement a way to set the quest "TimeLimit" after N days from current time and at fixed hour. https://github.com/rathena/rathena/pull/3586/files#diff-43df541b60840c825f4f8997d7e6fad0R2173
Implement vicious weapon charms (requires item_randomopt_group PR to yml)
Implement the skills
NPC_ELECTRICWALK
NPC_FIREWALK
NPC_HALLUCINATIONWALK
NPC_PHANTOMTHRUST
NPC_IGNITIONBREAK
NPC_CLOUD_KILL
NPC_POISON_BUSTER

Thanks to @admkakaroto and https://www.divine-pride.net/ for testing and some mobs infos

…sion)

db/re/item_db.txt

npc/re/instances/SkyFortrest.txt

@aleos89

Thanks to @aleos89 !

…ena/rathena into script/skyfortrest_instance # Conflicts: # npc/re/instances/SkyFortrest.txt

mjonrest · 2018-10-20T16:43:19Z

#3084 i saw this issue, can this also release??

AsurielRO · 2018-10-20T18:16:54Z

just a missing item will be drop and monster skills all over are fine

dev1-juan · 2018-11-09T10:36:23Z

what seems to be the last problem for it to be released?

Everade · 2018-12-29T03:54:01Z

Still missing are the Random Options on drop:
https://irowiki.org/wiki/Vicious_Mind_Weapon_Enchants

And there are missing "" in the Stephen J. E. Card
Should be:
31026,Stephen_Jack_Ernest_Wolf_Card,Stephen Jack Ernest Wolf Card,6,20,,10,,,,,,,,64,,,,,{ bonus5 bAutoSpellWhenHit,"SO_FIREWALK",5,35,BF_WEAPON,0; bonus5 bAutoSpellWhenHit,"SO_ELECTRICWALK",5,80,BF_MAGIC,0; autobonus "{ bonus bFlee,200; }",30,10000,BF_WEAPON; autobonus "{ bonus bSpeedRate,25; }",25,10000,BF_MAGIC; /* unknown rate and specialeffect */ },{},{}

# Conflicts: # db/re/item_combo_db.txt # db/re/mob_db.txt

* The quest log shouldn't change when using a ticket to enter * Added a check to warp back to his map entrance when player exit the instance

Updated the script using some news script commands

* Corrects the Sky Fortress Key Keeper spawn location and rates

npc/re/instances/SkyFortress.txt

* Enabled 'Sky Fortress Treasure Box' / Wind Ghost in Experiment NPC when the Immortal Death Shadow are spawn

reunite-ro · 2020-03-18T17:07:07Z

db/re/mob_db.txt

-//3483,AS_EVIL_SHADOW3
-//3484,AS_D_RAGGED_GOLEM
-//3485,AS_D_CURSED_SOLDIER
+3473,AS_RAGGED_GOLEM,Stefan.J.E.Wolf,Stefan.J.E.Wolf,160,20000000,1,1000000,1000000,1,1307,103,146,30,189,25,125,45,104,33,10,12,2,1,89,0x6283695,300,1008,1200,540,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,31026,1


seems like the monsters didnt have the proper item drop yet.

I've created a PR to amend this based on information from Divine-Pride and RMS DBs

npc/re/instances/SkyFortress.txt

db/re/item_db.txt

npc/re/instances/SkyFortress.txt

@latiosu

Corrected some npc name Thanks to @latiosu

* Implemented the items from sky fortress instance (part of #3586) Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>

Added random option drop in mob_drop.txt for monster from the instance

@Akaineko-astasi

* Took/corrected some skills from #4799 credit to @Akaineko-astasi

NPC_HALLUCINATIONWALK NPC_POISON_BUSTER NPC_CLOUD_KILL NPC_IGNITIONBREAK NPC_PHANTOMTHRUST NPC_FIREWALK NPC_ELECTRICWALK

src/map/skill.cpp

db/re/skill_db.yml

src/map/battle.cpp

@aleos89

Thanks to @aleos89 !

Initial release of Sky Fortress Invasion Instance (Walkthrough Conver…

31c7b22

…sion)

idamonli mentioned this pull request Oct 17, 2018

Some database updates. idathena/trunk#466

Closed

Implemented monsters cards

96aa7f5

aleos89 reviewed Oct 17, 2018

View reviewed changes

aleos89 and others added 3 commits October 17, 2018 15:56

Fix typo

5fcf1b4

Grammar fix

42eb2fe

Thanks to @aleos89 !

Merge branch 'script/skyfortrest_instance' of https://github.com/rath…

6803a50

…ena/rathena into script/skyfortrest_instance # Conflicts: # npc/re/instances/SkyFortrest.txt

Lemongrass3110 and others added 9 commits January 29, 2019 16:49

Merge branch 'master' into script/skyfortrest_instance

65172b8

# Conflicts: # db/re/item_combo_db.txt # db/re/mob_db.txt

Added the script for build bot validation

72b488a

Renamed the file

05c93df

Merge branch 'master' into script/skyfortrest_instance

7ee37c7

* Added missing inventory check when giving the rental item

d60488d

* The quest log shouldn't change when using a ticket to enter * Added a check to warp back to his map entrance when player exit the instance

Updated some comments

ca9c619

Updated the script using some news script commands

Corrected some monsters spawn

a873c8c

Corrected the monsters spawn inside the rooms

09f9c6d

* Corrects the system to warp the player in the rooms

108d48a

* Corrects the Sky Fortress Key Keeper spawn location and rates

Angelic234 reviewed Feb 8, 2020

View reviewed changes

npc/re/instances/SkyFortress.txt Outdated Show resolved Hide resolved

Angelic234 reviewed Feb 8, 2020

View reviewed changes

npc/re/instances/SkyFortress.txt Outdated Show resolved Hide resolved

Fix a mistake

8f7d032

* Enabled 'Sky Fortress Treasure Box' / Wind Ghost in Experiment NPC when the Immortal Death Shadow are spawn

reunite-ro reviewed Mar 18, 2020

View reviewed changes

Atemo and others added 4 commits April 11, 2020 15:20

Merge branch 'master' into script/skyfortrest_instance

ea01e30

Removed the old instance_db and quest_db files

c64a0a5

Merge branch 'master' into script/skyfortrest_instance

eaabe86

Updated the npcs and monsters spawn timer

59e9f9e

latiosu mentioned this pull request Apr 14, 2020

Update mobs for Sky Fortress #4797

Closed

Akaineko-astasi reviewed Apr 24, 2020

View reviewed changes

npc/re/instances/SkyFortress.txt Show resolved Hide resolved

Atemo added 5 commits June 18, 2020 18:48

Merge branch 'master' into script/skyfortrest_instance

17db5ec

Updated script using rentalcountitem

810e509

Updated item db

d3b4d84

Merge branch 'master' into script/skyfortrest_instance

0aa7248

(Re)added the cards

7638b1b

latiosu reviewed Jul 20, 2020

View reviewed changes

db/re/item_db.txt Outdated Show resolved Hide resolved

latiosu reviewed Jul 20, 2020

View reviewed changes

npc/re/instances/SkyFortress.txt Outdated Show resolved Hide resolved

Corrected Stephen_Jack_Ernest_Wolf_Card item script

cc363b2

Corrected some npc name Thanks to @latiosu

Atemo added a commit to Atemo/rathena that referenced this pull request Oct 24, 2020

Implemented the items from sky fortress instance (part of rathena#3586)

0e7eedb

Atemo mentioned this pull request Oct 24, 2020

Implemented the items from sky fortress instance #5479

Merged

Atemo added a commit that referenced this pull request Oct 25, 2020

Implemented the items from sky fortress instance (#5479)

99e75b0

* Implemented the items from sky fortress instance (part of #3586) Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>

Atemo added 11 commits October 25, 2020 23:30

Merge branch 'master' into script/skyfortrest_instance

1f3e1aa

Merge branch 'master' into script/skyfortrest_instance

6c91638

Updated mob_db.txt

d86ea10

Added random option drop in mob_drop.txt for monster from the instance

Added some monsters skills in mob_skill_db.txt

ae7095c

* Took/corrected some skills from #4799 credit to @Akaineko-astasi

Updates of the instance 'Sky Fortress'

bcc0e5b

Merge branch master

a1d2360

Added skills

82d187c

NPC_HALLUCINATIONWALK NPC_POISON_BUSTER NPC_CLOUD_KILL NPC_IGNITIONBREAK NPC_PHANTOMTHRUST NPC_FIREWALK NPC_ELECTRICWALK

Merge branch 'master' into script/skyfortrest_instance

468499a

Added the skills in prere

af7a103

Merge branch 'master' into script/skyfortrest_instance

4dda758

Added mob data

1df931f

aleos89 reviewed Feb 24, 2021

View reviewed changes

src/map/skill.cpp Outdated Show resolved Hide resolved

db/re/skill_db.yml Outdated Show resolved Hide resolved

db/re/skill_db.yml Outdated Show resolved Hide resolved

src/map/battle.cpp Outdated Show resolved Hide resolved

Lemongrass3110 and others added 3 commits February 24, 2021 15:56

Merged player and monster code

126b8fb

Corrections for code review

36dc615

Thanks to @aleos89 !

Final review

ce1c37f

Atemo merged commit 95c671a into master Mar 8, 2021

Atemo deleted the script/skyfortrest_instance branch March 8, 2021 14:12

Atemo changed the title ~~Initial release of Sky Fortress Invasion Instance (Walkthrough Conversion)~~ Initial release of Sky Fortress Invasion Instance (Official Conversion) Mar 8, 2021

Lemongrass3110 mentioned this pull request Jan 16, 2023

Implement new mob skills #1525

Open

81 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial release of Sky Fortress Invasion Instance (Official Conversion) #3586

Initial release of Sky Fortress Invasion Instance (Official Conversion) #3586

Atemo commented Oct 16, 2018 •

edited

mjonrest commented Oct 20, 2018

AsurielRO commented Oct 20, 2018

dev1-juan commented Nov 9, 2018

Everade commented Dec 29, 2018 •

edited

reunite-ro Mar 18, 2020

latiosu Apr 14, 2020

Initial release of Sky Fortress Invasion Instance (Official Conversion) #3586

Initial release of Sky Fortress Invasion Instance (Official Conversion) #3586

Conversation

Atemo commented Oct 16, 2018 • edited

mjonrest commented Oct 20, 2018

AsurielRO commented Oct 20, 2018

dev1-juan commented Nov 9, 2018

Everade commented Dec 29, 2018 • edited

reunite-ro Mar 18, 2020

Choose a reason for hiding this comment

latiosu Apr 14, 2020

Choose a reason for hiding this comment

Atemo commented Oct 16, 2018 •

edited

Everade commented Dec 29, 2018 •

edited