Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed clearing of sp_vanish_race #3729

Merged
merged 1 commit into from Dec 8, 2018
Merged

Fixed clearing of sp_vanish_race #3729

merged 1 commit into from Dec 8, 2018

Conversation

secretdataz
Copy link
Member

@secretdataz secretdataz commented Dec 6, 2018 •
edited

  • Addressed Issue(s): -
  • Server Mode: Both
  • Description of Pull Request:
    Fixed a bug caused by 1210 bytes offset in a memset call.
    Don't submit a pull request 10 minutes before exam

Still need further investigation for other offset'd calls.

@Lemongrass3110 Lemongrass3110 changed the title Hotfix for item bonus not being cleared properly. Fixed clearing of sp_vanish_race Dec 8, 2018
@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:bug Issue that is a bug within rAthena labels Dec 8, 2018
@Lemongrass3110 Lemongrass3110 merged commit 4cff45b into master Dec 8, 2018
@Lemongrass3110 Lemongrass3110 deleted the hotfix/bonus branch December 8, 2018 19:04
SeravySensei pushed a commit to SeravySensei/rathena that referenced this pull request Jan 26, 2019
@secretdataz @SeravySensei
Fixed clearing of sp_vanish_race (rathena#3729)
1d0edc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemongrass3110 Lemongrass3110 Lemongrass3110 approved these changes

@aleos89 aleos89 aleos89 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@secretdataz @Lemongrass3110 @aleos89