Splitted guild_skill_tree.txt into re and pre-re #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Daegaladh
commented
Jan 7, 2019
•
Daegaladh
commented
- Addressed Issue(s): Guild Storage Expansion on Pre-renewal #3840
- Server Mode: Both
- Description of Pull Request:
- Split guild_skill_tree into re and pre-re, Guild Storage Expansion skill left commented on pre-re for custom use.
- Converted guild_skill_tree to YAML.
Daegaladh
added
the
status:code-review
aleos89
approved these changes
Jan 7, 2019
Lemongrass3110
previously approved these changes
Jan 7, 2019
* Skipped during conversion.
|
Blocked until #3694 was merged. |
Lemongrass3110
added
the
status:onhold
Atemo
reviewed
Jan 28, 2019
src/map/guild.cpp
Outdated
| yaml_invalid_warning("guild_read_guildskill_tree_db_sub: Guild skill definition with invalid ID field in '" CL_WHITE "%s" CL_RESET "', skipping.\n", node, source); | ||
| return false; | ||
| } | ||
| if (!script_get_constant(name.c_str(), (int *)&skill_id)) { |
There was a problem hiding this comment.
How about int skill_id = skill_name2id( name.c_str() ); instead?
* Adjusted guild skill name parsing to use previously defined functions so we don't have to export skill names to the script engine. Thanks to @Atemo's suggestion!
secretdataz
removed
the
status:onhold
aleos89
removed
the
status:code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.