Fixed pet eggs as mail attachments #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4327 Thanks to @RadianFord
Lemongrass3110
added
component:core
Daegaladh
requested changes
Jan 3, 2020
Daegaladh
approved these changes
Jan 3, 2020
aleos89
approved these changes
Jan 3, 2020
Lemongrass3110
removed
the
status:code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue(s): Pet egg as mail attachment #4327
Server Mode: Both
Description of Pull Request:
Fixes the issue by adding a check when getting the attachments of a mail. This additional check ensures that pet eggs that do not have a pet id stored in their card slot get their pet data/id generated by the inter server.
Thanks to @RadianFord