Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dead monsters stuck after killed #5263

Merged
merged 5 commits into from May 20, 2022
Merged

Fixed dead monsters stuck after killed #5263

merged 5 commits into from May 20, 2022

Conversation

Daegaladh
Copy link
Member

*Thanks to @Hope8888

  • Server Mode: Both
  • Description of Pull Request: Avoids monsters moving after dead so they don't get stuck on screen

@Daegaladh Daegaladh added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Jul 30, 2020
@Daegaladh Daegaladh added status:inprogress Issue that has begun resolution by a developer and removed status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Aug 3, 2020
@Daegaladh
Copy link
Member Author

Still happens on some cases (when the monster dies while you're moving and the monsters gets momentarily out of sight range), we'll need to dig deeper and find the ultimate cause

@Daegaladh Daegaladh added status:need more info Issue that needs more information from a creditable source and removed status:inprogress Issue that has begun resolution by a developer labels Aug 19, 2020
@saya9200
Copy link

I just tested this. Before applying the pull request, it happened very very often. Now it doesnt happen at all to me.

@Daegaladh
Copy link
Member Author

I just tested this. Before applying the pull request, it happened very very often. Now it doesnt happen at all to me.

Unfortunately it causes some undesirable side effects (monsters stopping and other weird stuff), we need to check this thoroughly

@lighta
Copy link
Member

lighta commented Nov 30, 2020

You could try to reduce this check only for mob and not al the BL, just to see if that reduce the side effect.

@Daegaladh
Copy link
Member Author

You could try to reduce this check only for mob and not al the BL, just to see if that reduce the side effect.

They still don't move correctly :/

@attackjom
Copy link
Contributor

this fix from Hercules HerculesWS/Hercules@c04d791

can solve the issue "when the monster dies while you're moving and the monsters gets momentarily out of sight range".

@Daegaladh Daegaladh requested a review from aleos89 May 19, 2022 09:42
@Daegaladh Daegaladh added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena and removed status:need more info Issue that needs more information from a creditable source labels May 19, 2022
Copy link
Contributor

@Daraen1 Daraen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be good for me, work fine ;)

GG!

@Daegaladh Daegaladh merged commit fa363b9 into master May 20, 2022
@Daegaladh Daegaladh deleted the hotfix/issue5064 branch May 20, 2022 11:27
@Daegaladh Daegaladh removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants