Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dead monsters stuck after killed #5263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed dead monsters stuck after killed #5263

wants to merge 2 commits into from

Conversation

Daegaladh
Copy link
Member

@Daegaladh Daegaladh commented Jul 30, 2020

*Thanks to @Hope8888

  • Addressed Issue(s): #5064
  • Server Mode: Both
  • Description of Pull Request: Avoids monsters moving after dead so they don't get stuck on screen

@Daegaladh
Copy link
Member Author

@Daegaladh Daegaladh commented Aug 3, 2020

Still happens on some cases (when the monster dies while you're moving and the monsters gets momentarily out of sight range), we'll need to dig deeper and find the ultimate cause

@saya9200
Copy link

@saya9200 saya9200 commented Sep 22, 2020

I just tested this. Before applying the pull request, it happened very very often. Now it doesnt happen at all to me.

@Daegaladh
Copy link
Member Author

@Daegaladh Daegaladh commented Sep 22, 2020

I just tested this. Before applying the pull request, it happened very very often. Now it doesnt happen at all to me.

Unfortunately it causes some undesirable side effects (monsters stopping and other weird stuff), we need to check this thoroughly

@lighta
Copy link
Member

@lighta lighta commented Nov 30, 2020

You could try to reduce this check only for mob and not al the BL, just to see if that reduce the side effect.

@Daegaladh
Copy link
Member Author

@Daegaladh Daegaladh commented Nov 30, 2020

You could try to reduce this check only for mob and not al the BL, just to see if that reduce the side effect.

They still don't move correctly :/

@attackjom
Copy link
Contributor

@attackjom attackjom commented Jan 14, 2022

this fix from Hercules HerculesWS/Hercules@c04d791

can solve the issue "when the monster dies while you're moving and the monsters gets momentarily out of sight range".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants