Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latiosu feat/docker #5572

Merged
merged 5 commits into from Nov 26, 2020
Merged

Latiosu feat/docker #5572

merged 5 commits into from Nov 26, 2020

Conversation

lighta
Copy link
Member

@lighta lighta commented Nov 25, 2020

  • Addressed Issue(s): None
  • Server Mode: Both
  • Description of Pull Request:
    Adds an easy way for developers new to rAthena to get a local development environment up and running with only a single pre-requisite (Docker Desktop).

Instructions for use:

  1. docker-compose up -d to spin up database (automatically imports /sql-files/*.sql on first load)
  2. docker exec -it rathena bash to connect to lightweight linux container with all rathena dependencies (plus gdb)
  3. Devs can now run usual commands (./configure, make, etc ...) or start server (./athena-start, gdb map-server, etc ...)
  4. docker-compose down to free resources when done

Demonstration: https://terminalizer.com/view/c05443023904

Additional Information:

  • Database is persisted to local disk so no need to recreate database every time.
  • First time the database volume is created, all *.sql files are imported into the database. This does not happen on future start ups unless the volume has been deleted (devs can delete volume with docker-compose down --volumes)
  • Devs can inspect state of containers with docker-compose ps and modify the setup as they see fit (Official Docs: https://docs.docker.com/compose/compose-file/)

@lighta
Copy link
Member Author

lighta commented Nov 25, 2020

@latiosu updated with minor changes

@Normynator Normynator self-requested a review November 25, 2020 03:34
@Normynator
Copy link
Contributor

lgtm!

@lighta lighta merged commit 629c7b5 into master Nov 26, 2020
@lighta lighta deleted the Latiosu-feat/docker branch November 26, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants