Initial support for web service for newer clients

[vstumpf]

• Addressed Issue(s): N/A

• Server Mode: Both

• Description of Pull Request: C++ Implementation of the Web Service required by newer clients.

Thanks @secretdataz for the athena-web-service, which I got the schemas from.

Using CMake

• cmake -DENABLE_WEB_SERVER

Using Visual Studio

• enable the web and httplib projects in visual studio

Features:

• Supports bmp emblems
• Supports gif emblems
• Supports user configs (get rid of that pesky "Your account configs could not be loaded, please retry later"!)

Todos:

• Test it (lmao)
• Transparency check
• Stop emblem change in WoE

Possible future extensions

• Support multiple char servers (idk if needed)
• Clean up sqllock
• Support other emblem formats and convert it to correct size/bmp type.
• Support the twitter integration

[LolyAll]

Warnings:

11>F:\GitHub\rathena\src\common\cbasetypes.hpp(231,1): warning C4005: 'strcasecmp': macro redefinition
11>F:\GitHub\rathena\3rdparty\httplib\httplib.h(152): message : see previous definition of 'strcasecmp'
11>F:\GitHub\rathena\src\common\cbasetypes.hpp(231,1): warning C4005: 'strcasecmp': macro redefinition
11>F:\GitHub\rathena\3rdparty\httplib\httplib.h(152): message : see previous definition of 'strcasecmp'
11>F:\GitHub\rathena\src\web\emblem_controller.cpp(98,33): warning C4244: 'argument': conversion from 'std::streamoff' to 'size_t', possible loss of data
11>F:\GitHub\rathena\src\common\cbasetypes.hpp(231,1): warning C4005: 'strcasecmp': macro redefinition
11>F:\GitHub\rathena\3rdparty\httplib\httplib.h(152): message : see previous definition of 'strcasecmp'

and, are not working, its necessary configure something in lua files?

[vstumpf]

There's a lot of warnings in the http lib project, but since it's not our code (3rd party), I don't want to try to fix them.
Ideally, you're not building it every time too, just once.

You need to set up the External settings lua file and point it to the ip of your host and the port that's set in web_athena.conf

[eppc0330]

I don't know what error is this... I have patched all but doesn't work.

Also web-server console cannot read Korean. How to do?

[reunite-ro]

I got this log.

[vstumpf]

These logs are because I forgot to put a conf for logging the request/responses.

Also web-server console cannot read Korean. How to do?

I don't understand, what do you mean? It looks like the console logs correctly.
You can ignore the "not authorized, why?" error, I have to remove the message.

[vstumpf]

For emblems, you need to create the guild_emblem_dir yourself. I've added an error message in web-server startup. I can't do this automatically since there's no portable way to make directories in c++11.

I've created a config option for the full logging, print_res_req, it's off by default.
Removed the sql lock debug messages.

Added a nginx-like log message, it looks like this:
[Info]: 172.19.0.1 [POST /userconfig/load] 200

[reunite-ro]

response status 404 is regarding what ya ?
I dont get any issue with user configs but emblems are still having 404.
The directory emblems warning also gone since ive create it.

[vstumpf]

What's your client version?
What were you doing that causes the error? A 404 is only when you try to download a guild emblem that hasn't been uploaded yet.

[reunite-ro]

What's your client version?
What were you doing that causes the error? A 404 is only when you try to download a guild emblem that hasn't been uploaded yet.

Im using 20200304 RE client and also have Gepard included.

The guild_emblems warning will not be shown if I create the folder in rathena folder. But I dont think people can access it via http since its in rathena folder, not webserver.

[eppc0330]

These logs are because I forgot to put a conf for logging the request/responses.

Also web-server console cannot read Korean. How to do?

I don't understand, what do you mean? It looks like the console logs correctly.
You can ignore the "not authorized, why?" error, I have to remove the message.

When I use Korean world name, it displayed weirdly.

[eppc0330]

Is this packet error?

Pet gets guild emblem, too.

[vstumpf]

The guild_emblem_dir should be made in rathena folder, same level as web-server.exe, db, conf, etc.

Is this packet error?
Pet gets guild emblem, too.

I have no idea, that might be intended by the client

[admkakaroto]

@vstumpf Congrats by the incredible work.

But uploading images in .gif is crashing the webserver, .bmp is working properly.

[vstumpf]

Ok, no meme, are .gifs supposed to work for guild emblems?

How big is the .gif? (can you just share it here or on discord, nitrous#0001)

[admkakaroto]

Ok, no meme, are .gifs supposed to work for guild emblems?

How big is the .gif? (can you just share it here or on discord, nitrous#0001)

the maximum size I don't know, the dimensions are the same, 24x24px, since the client 2020 that gif is supported.

[admkakaroto]

Im not at home, but in 2 hours i eill send to you more infos.

[attackjom]

24x24 bmp / gif with less than 50 kbp

[vstumpf]

I've added support for gif emblems, and this requires a new column in the guild_emblems table. Unfortunately, you'll have to drop your tables.

I also start the http server on a separate thread, so the sql keepalives actually trigger.

[JosueWu]

Do you happen to know if they will add this to the main emulator or add another solution to display the guild emblems?

[vstumpf]

Do you happen to know if they will add this to the main emulator?

That is the intention with this PR. If you would like a php version, you can use athena-web-service

[admkakaroto]

@vstumpf after new commits web are not working anymore:

after show this error, this window closes.

[admkakaroto]

The problem is be caused by this commit: 5eed958

[vstumpf]

Are you on windows? It works fine on ubuntu20. I'll look into it.

[admkakaroto]

Are you on windows? It works fine on ubuntu20. I'll look into it.

Yes, windows 10 x64, VS2019