Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up some cast time and delay behaviors #6221

Merged
merged 3 commits into from Aug 31, 2021
Merged

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Aug 26, 2021

  • Addressed Issue(s): Fixes After Cast Delay Reduction Algorithm #6135

  • Server Mode: Pre-renewal and Renewal

  • Description of Pull Request:

    • Mystical Amplification should not have the IgnoreStatus CastTime flag.
    • Foresight will only apply a cast reduction to learned skills, not those that are granted through item bonuses, guild skills, pets, etc.
    • Item bonus bDelayRate will now stack with other delay reduction bonuses.
    • General cleanups to variable defines.
      Thanks to @Everade and @mrjnumber1!

* Fixes #6135.
* Mystical Amplification should not have the IgnoreStatus CastTime flag.
* Foresight will only apply a cast reduction to learned skills, not those that are granted through item bonuses guild skills, pets, etc.
* Item bonus bDelayRate will now stack with other delay reduction bonuses.
* General cleanups to variable defines.
Thanks to @Everade and @mrjnumber1!
@aleos89 aleos89 added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Aug 26, 2021
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
aleos89 and others added 2 commits August 26, 2021 14:56
Sorry my fault ;-)
@aleos89 aleos89 merged commit 9e4dc7d into master Aug 31, 2021
@aleos89 aleos89 deleted the hotfix/issue6135 branch August 31, 2021 12:54
@aleos89 aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Cast Delay Reduction Algorithm
2 participants