Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update *plagiarizeskill and *plagiarizedreset script command #7394

Merged
merged 2 commits into from Nov 2, 2022

Conversation

Emistry
Copy link
Contributor

@Emistry Emistry commented Oct 29, 2022

  • Addressed Issue(s):
    plagiarized skill doesn't work
    fix unable to reset plagiarized skill
  • Server Mode:
  • Description of Pull Request:
    fix so that allow player to reset plagiarized skill
    update plagiarizeskill(...) script command documentation to avoid confusion when plagiarize a skill
Note:
 - Plagiarism only able to copy skill while SC_PRESERVE is not active and skill is copyable by Plagiarism.
 - Reproduce can copy skill if SC__REPRODUCE is active and the skill is copyable by Reproduce.

fix player unable to reset plagiaried skills.
Script commands only work if they meet the skills condition.
@aleos89 aleos89 merged commit 88d6d79 into rathena:master Nov 2, 2022
Singe-Horizontal pushed a commit to Singe-Horizontal/rathena that referenced this pull request Nov 5, 2022
* Fix plagiarizeskillreset unable to reset.
* Update plagiarizeskill documentation.
@Emistry Emistry deleted the src_skill_plagiarism_reset branch February 3, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants