create Soul reaper job change quest #8159
Open
+1,164
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct comparations in conditions for some base level achievements to work with the multi level check of achievements.
Add the quest and the instance to the db for the soul reaper job quest.
Add soul reaper job change quest.
|
Thanks you for your work. Before any review I have a few questions. |
Yes, the script is based on the video, is written in the script header, so the dialogs are the ones that appear in the video, and yes, lately I'll comment the fill dialogs . |
|
Did you use a replay parser? |
What do you mean by that? Edit: I just write everything by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing quest for soul reaper job.
Renewal.
Create the files in db for quest and instace for the soul repaer job change quest and add the script for the quest.